Show the path, when the filename conflicts

[nickvergessen]

Fix #1791

@jancborchardt @ChristophWurst @MorrisJobke

Steps

1. Create a/shared, b/shared, {root}shared
2. Share all with link
3. Go to the "Shared by link" tab and try to identify them...

[mention-bot]

@nickvergessen, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jancborchardt, @PVince81 and @butonic to be potential reviewers.

[rullzer]

LGTM! Awesome stuff!

[MorrisJobke]

Tested and works 👍

(in this case share is also in a but doesn't has a name conflict so the full path is not shown ;))

[zwotzie]

I would say this solution is good, but not perfekt.

The preferred way would be to show the path always. I'll try to explain why:

• for me it is inconsistent
• you always want to know where
• (best would be to be able to customize the view in the settings, because everybody has his own opinion)
  All the best.

[jancborchardt]

@zwotzie

• for me it is inconsistent

It’s only needed when the folder / file names actually conflict. Nothing inconsistent here. We also don’t show the full path of every file in the normal file list. So showing it always here would actually be inconsistent.

• you always want to know where

How so? It’s a shortcut. Check the Nautilus sidebar for example or other apps where you have a favorites setting. None of them have the full path always. It’s just too much unnecessary info.

• (best would be to be able to customize the view in the settings, because everybody has his own opinion)

Introducing a setting for every little thing is just not how we handle things at Nextcloud. If we have a ton of settings, the important settings can’t be found anymore. :) And then the software ends up like so much open source software: sadly very hard to use.

[roomanus]

#1791