Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly handle resources in ReminderService #18115

Merged
merged 1 commit into from
Dec 27, 2019
Merged

Properly handle resources in ReminderService #18115

merged 1 commit into from
Dec 27, 2019

Conversation

georgehrke
Copy link
Member

fixes #17951

@georgehrke
Properly handle resources in ReminderService
05e47af 
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
@georgehrke georgehrke added the 3. to review Waiting for reviews label Nov 26, 2019
@georgehrke georgehrke mentioned this pull request Nov 26, 2019
Closed
@georgehrke
Copy link
Member Author

waiting for responses in #17951, will request reviews after that

@georgehrke
Copy link
Member Author

Responses in #17951 are positive that this fixes the issue

@kesselb
Copy link
Contributor

kesselb commented Nov 29, 2019

Code looks good. Have you found a way to reproduce it?

server/apps/dav/lib/CalDAV/Reminder/Backend.php

Line 207 in c7d5b8f

private function fixRowTyping(array $row): array {
probably it's possible to do stream_get_contents here. No duplicate code than ;)

@tcitworld
Copy link
Member

I reproduce it too on my own production server.

@gary-kim gary-kim added the bug label Dec 24, 2019
@gary-kim gary-kim added this to the Nextcloud 18 milestone Dec 24, 2019
gary-kim
gary-kim approved these changes Dec 27, 2019
View reviewed changes
Copy link
Member

@gary-kim gary-kim left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gary-kim gary-kim added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 27, 2019
This was referenced Dec 27, 2019
Merged
Merged
@rullzer rullzer merged commit b7f93cc into master Dec 27, 2019
@rullzer rullzer deleted the bugfix/17951/reminderservice_resource_error branch December 27, 2019 13:42
@enoch85
Copy link
Member

enoch85 commented Dec 28, 2019

Thanks! I don't see any backport request, would that be possible?

@georgehrke
Copy link
Member Author

/backport to stable17

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jan 14, 2020
Merged
@backportbot-nextcloud
Copy link

backport to stable17 in #18880

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kesselb kesselb kesselb approved these changes

@gary-kim gary-kim gary-kim approved these changes

@rullzer rullzer Awaiting requested review from rullzer

@tcitworld tcitworld Awaiting requested review from tcitworld tcitworld is a code owner

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish bug
Projects
None yet
Milestone
Nextcloud 18.0.0
Development

Successfully merging this pull request may close these issues.

ReminderService::parseCalendarData() must be of the type string
6 participants
@georgehrke @kesselb @tcitworld @enoch85 @gary-kim @rullzer