Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Register with potentially updated namespace #18862

Merged
merged 2 commits into from Jan 14, 2020
Merged

Register with potentially updated namespace #18862

merged 2 commits into from Jan 14, 2020

Conversation

nickvergessen
Copy link
Member

@nickvergessen
Register the namespace after reading the new file
efcf246 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Allow to force register the namespace
df9edf0 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added this to the Nextcloud 18 milestone Jan 13, 2020
@rullzer rullzer modified the milestones: Nextcloud 18, Nextcloud 19 Jan 13, 2020
@rullzer
Copy link
Member

rullzer commented Jan 13, 2020

/backport to stable18

rullzer
rullzer approved these changes Jan 13, 2020
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘 I trust the almighty talk wizard ✨

blizzz
blizzz approved these changes Jan 13, 2020
View reviewed changes
Copy link
Member

@blizzz blizzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reasonable

@blizzz blizzz added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 13, 2020
kesselb
kesselb approved these changes Jan 13, 2020
View reviewed changes
Copy link
Contributor

@kesselb kesselb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 I guess getAppInfo is not using autoload to fetch information.

@rullzer rullzer merged commit bda6766 into master Jan 14, 2020
@rullzer rullzer deleted the bugfix/talk-2663/register-with-potentially-updated-namespace branch January 14, 2020 07:37
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jan 14, 2020
Merged
@backportbot-nextcloud
Copy link

backport to stable18 in #18879

@nickvergessen nickvergessen mentioned this pull request Jan 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer rullzer approved these changes

@blizzz blizzz blizzz approved these changes

@kesselb kesselb kesselb approved these changes

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: install and update
Projects
None yet
Milestone
Nextcloud 19
Development

Successfully merging this pull request may close these issues.

Failed to run Repair steps on ugrade to server 18 RC 1
4 participants
@nickvergessen @rullzer @blizzz @kesselb