Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Sidebar legacy FileInfoModel requirement #18927

Merged
merged 1 commit into from
Jan 16, 2020
Merged

Fix Sidebar legacy FileInfoModel requirement #18927

merged 1 commit into from
Jan 16, 2020

Conversation

skjnldsv
Copy link
Member

Because the sidebar legacy tabs require the fileinfo to be set with the FileInfoModel

server/apps/files/src/components/LegacyTab.vue

Line 88 in ec01e0a

this.component.setFileInfo(new OCA.Files.FileInfoModel(fileInfo))
, we need to have it available

@skjnldsv
Fix Sidebar legacy FileInfoModel requirement
613860e 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added bug 3. to review Waiting for reviews feature: file sidebar Related to the file sidebar component labels Jan 16, 2020
@skjnldsv skjnldsv added this to the Nextcloud 18.0.0 milestone Jan 16, 2020
@skjnldsv skjnldsv self-assigned this Jan 16, 2020
@skjnldsv skjnldsv added the high label Jan 16, 2020
@skjnldsv
Copy link
Member Author

/backport to stable18

gary-kim
gary-kim approved these changes Jan 16, 2020
View reviewed changes
Copy link
Member

@gary-kim gary-kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 16, 2020
@skjnldsv skjnldsv merged commit cf771c5 into master Jan 16, 2020
@skjnldsv skjnldsv deleted the fix/sidebar/fileinfomodel branch January 16, 2020 16:12
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jan 16, 2020
Merged
@backportbot-nextcloud
Copy link

backport to stable18 in #18934

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer rullzer approved these changes

@gary-kim gary-kim gary-kim approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@juliushaertl juliushaertl Awaiting requested review from juliushaertl

Assignees

@skjnldsv skjnldsv

Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: file sidebar Related to the file sidebar component high
Projects
None yet
Milestone
Nextcloud 18.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@skjnldsv @rullzer @gary-kim