-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nextcloud runs only on PHP 5.6+ #1898
Conversation
@MorrisJobke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @LukasReschke, @DeepDiver1975 and @owncloud-bot to be potential reviewers. |
// Show warning if a PHP version below 5.6.0 is used, this has to happen here | ||
// because base.php will already use 5.6 syntax. | ||
if (version_compare(PHP_VERSION, '5.6.0') === -1) { | ||
echo 'This version of Nextcloud requires at least PHP 5.4.0'.PHP_EOL; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't lie ;) Its 5.6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙈 Fixed
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
88658e3
to
6df9090
Compare
👍 |
Current coverage is 57.28% (diff: 0.00%)@@ master #1898 diff @@
==========================================
Files 1075 1075
Lines 61319 61319
Methods 6851 6851
Messages 0 0
Branches 0 0
==========================================
- Hits 35125 35124 -1
- Misses 26194 26195 +1
Partials 0 0
|
LGTM |
cc @LukasReschke @rullzer @nickvergessen