remove slight transparency of primary action button, ref #1615

[jancborchardt]

Fix the first part of @ChristophWurst’s comment in #1615 (comment) about the log in button when themed

@juliushaertl how would I use the class .icon-confirm (instead of .icon-confirm-white) when the primary color is set so the text switches to black? :)

cc @nextcloud/designers

[mention-bot]

@jancborchardt, thanks for your PR! By analyzing the history of the files in this pull request, we identified @juliushaertl, @LukasReschke and @schiessle to be potential reviewers.

[juliushaertl]

@jancborchardt The simple way would be to add a custom css rule over here and overwrite the icon used in the button:

server/apps/theming/lib/Controller/ThemingController.php

Lines 394 to 401 in 551cffd

	if($this->util->invertTextColor($color)) {
	$responseCss .= '#header .header-appname, #expandDisplayName { color: #000000; }' . "\n";
	$responseCss .= '#header .icon-caret { background-image: url(\'' . \OC::$WEBROOT . '/core/img/actions/caret-dark.svg\'); }' . "\n";
	$responseCss .= '.searchbox input[type="search"] { background: transparent url(\'' . \OC::$WEBROOT . '/core/img/actions/search.svg\') no-repeat 6px center; color: #000; }' . "\n";
	$responseCss .= '.searchbox input[type="search"]:focus,.searchbox input[type="search"]:active,.searchbox input[type="search"]:valid { color: #000; border: 1px solid rgba(0, 0, 0, .5); }' . "\n";
	$responseCss .= '.nc-theming-contrast {color: #000000}' . "\n";
	$responseCss .= '.ui-widget-header { color: #000000; }' . "\n";
	} else {

And of course adapt the unit tests to match the changes. 😉

[jancborchardt]

@juliushaertl thanks a lot! Fixed it and hopefully I also fixed the tests correctly. :D

Please review @nextcloud/designers

[codecov-io]

Current coverage is 57.74% (diff: 100%)

Merging #1903 into master will increase coverage by 0.25%

@@             master      #1903   diff @@
==========================================
  Files          1075       1078      +3   
  Lines         61215      62411   +1196   
  Methods        6864       7075    +211   
  Messages          0          0           
  Branches          0          0           
==========================================
+ Hits          35194      36039    +845   
- Misses        26021      26372    +351   
  Partials          0          0           

Diff Coverage	File Path
•••••••••• 100%	apps/theming/lib/Controller/ThemingController.php

Powered by Codecov. Last update 324e5b0...cbd9fb3

[jancborchardt]

@LukasReschke @MorrisJobke can we deactivate the codecov comments? It’s already shown in the PR summary below and is a lot of noise. :)

[MorrisJobke]

@LukasReschke @MorrisJobke can we deactivate the codecov comments? It’s already shown in the PR summary below and is a lot of noise. :)

#1949

[juliushaertl]

👍

[LukasReschke]

LGTM