Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable18] Give the sharing tab a unique id so it also opens properly on other languages #19212

Merged
merged 3 commits into from Jan 30, 2020

Conversation

skjnldsv
Copy link
Member

Backport of #19125

juliushaertl and others added 3 commits January 30, 2020 09:41
…anguages

Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added bug 3. to review Waiting for reviews feature: file sidebar Related to the file sidebar component labels Jan 30, 2020
@skjnldsv skjnldsv added this to the Nextcloud 18.0.1 milestone Jan 30, 2020
@skjnldsv skjnldsv self-assigned this Jan 30, 2020
@skjnldsv skjnldsv changed the title Give the sharing tab a unique id so it also opens properly on other languages [stable18] Give the sharing tab a unique id so it also opens properly on other languages Jan 30, 2020
@skjnldsv
Copy link
Member Author

Failures unrelated, they are on stable18 as well https://drone.nextcloud.com/nextcloud/server/25653

@juliushaertl juliushaertl added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 30, 2020
@rullzer rullzer merged commit 297debe into stable18 Jan 30, 2020
@rullzer rullzer deleted the backport/19125/bugfix/noid/tab-id branch January 30, 2020 21:10
@rullzer rullzer mentioned this pull request Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: file sidebar Related to the file sidebar component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants