Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use toasts from @nextcloud/dialogs, deprecate OCP.Toast and fix usages #19346

Merged
merged 3 commits into from
Apr 6, 2020
Merged

Use toasts from @nextcloud/dialogs, deprecate OCP.Toast and fix usages #19346

merged 3 commits into from
Apr 6, 2020

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst added this to the Nextcloud 19 milestone Feb 7, 2020
@ChristophWurst ChristophWurst self-assigned this Feb 7, 2020
@ChristophWurst ChristophWurst added this to TO REVIEW (max 4 PRs) in Christoph's Tasks via automation Feb 7, 2020
@ChristophWurst ChristophWurst mentioned this pull request Feb 7, 2020
Merged
@ChristophWurst ChristophWurst added the pending documentation This pull request needs an associated documentation update label Feb 7, 2020
Christoph's Tasks automation moved this from TO REVIEW (max 4 PRs) to TO INTEGRATE Feb 7, 2020
@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 7, 2020
@rullzer rullzer added 2. developing Work in progress and removed 4. to release Ready to be released and/or waiting for tests to finish labels Feb 8, 2020
@rullzer
Copy link
Member

rullzer commented Feb 8, 2020

jsunit does boom https://drone.nextcloud.com/nextcloud/server/25909/1/2

@rullzer rullzer mentioned this pull request Feb 9, 2020
Closed
@ChristophWurst ChristophWurst force-pushed the refactor/external-toast-deprecate branch from b9e7d40 to f83c11e Compare February 14, 2020 17:10
@ChristophWurst
Copy link
Member Author

@juliushaertl it's the selector option in Toastify. It was changed with https://github.com/nextcloud/nextcloud-dialogs/pull/84/files#diff-1355aca4c744fdba046148edea3fb816R70. The current one is

server/core/src/OCP/toast.js

Line 78 in 6a1ba81

selector: !window.TESTING ? 'content' : 'testArea',
. Was this changed intentionally?

@juliushaertl
Copy link
Member

Was this changed intentionally?

Ah no, it was mainly because i wasn't thinking that we still might need the fallback for the old jsunit tests. I'd say we make the selector an option in the nextcloud-dialogs implementation and then can just pass in !window.TESTING ? 'content' : 'testArea' in the OCP.Toast wrapper.

@ChristophWurst ChristophWurst mentioned this pull request Mar 2, 2020
Merged
@ChristophWurst
Copy link
Member Author

ChristophWurst commented Mar 2, 2020 •
edited

I'd say we make the selector an option in the nextcloud-dialogs implementation and then can just pass in !window.TESTING ? 'content' : 'testArea' in the OCP.Toast wrapper.

@ChristophWurst ChristophWurst mentioned this pull request Mar 6, 2020
Merged
@ChristophWurst ChristophWurst force-pushed the refactor/external-toast-deprecate branch 2 times, most recently from 1857db5 to 7d4d371 Compare March 6, 2020 14:27
@ChristophWurst ChristophWurst mentioned this pull request Mar 9, 2020
Closed
@georgehrke georgehrke mentioned this pull request Mar 9, 2020
Closed
@ChristophWurst ChristophWurst mentioned this pull request Mar 9, 2020
Closed
@ChristophWurst ChristophWurst force-pushed the refactor/external-toast-deprecate branch from 7d4d371 to b1419ba Compare March 9, 2020 10:23
@ChristophWurst
Copy link
Member Author

Tests finally pass locally 😅

@ChristophWurst ChristophWurst added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Mar 9, 2020
@rullzer
Copy link
Member

rullzer commented Apr 4, 2020

get in or 20?

@rullzer rullzer mentioned this pull request Apr 4, 2020
Merged
80 tasks
@ChristophWurst
Copy link
Member Author

get in or 20?

let me rebase. I'd prefer to get this in sooner than later

@ChristophWurst
Use external Toast implementation and deprecate the OCP API
01a70e5 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst
Inline usages of OCP.Toast in bundled files
8119e0b 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst
Remove toastify-js
689ec7e 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst force-pushed the refactor/external-toast-deprecate branch from b1419ba to 689ec7e Compare April 6, 2020 15:20
@juliushaertl juliushaertl added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 6, 2020
@rullzer rullzer merged commit 5a82de1 into master Apr 6, 2020
Christoph's Tasks automation moved this from TO INTEGRATE to DONE Apr 6, 2020
@rullzer rullzer deleted the refactor/external-toast-deprecate branch April 6, 2020 18:45
@ChristophWurst ChristophWurst removed the pending documentation This pull request needs an associated documentation update label Apr 10, 2020
ChristophWurst added a commit to nextcloud/documentation that referenced this pull request Apr 10, 2020
@ChristophWurst
Update deprecated globals in 19
6df2b50 
Ref nextcloud/server#19455
Ref nextcloud/server#19346
Ref nextcloud/server#15403

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst mentioned this pull request Apr 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliushaertl juliushaertl juliushaertl approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@rullzer rullzer Awaiting requested review from rullzer

Assignees

@ChristophWurst ChristophWurst

Labels
4. to release Ready to be released and/or waiting for tests to finish technical debt
Projects
No open projects
Christoph's Tasks
DONE
Milestone
Nextcloud 19
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ChristophWurst @rullzer @juliushaertl @skjnldsv