Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable timeout on app install via cli #19430

Merged
merged 1 commit into from Feb 12, 2020

Conversation

blizzz
Copy link
Member

@blizzz blizzz commented Feb 12, 2020

this helps at least with installation/updating of big apps via CLI. Web UI is a different story, still.

@blizzz
Copy link
Member Author

blizzz commented Feb 12, 2020

/backport to stable18

@blizzz
Copy link
Member Author

blizzz commented Feb 12, 2020

related issues: #17808 #17776 nextcloud/documentserver_community#26 (they are also all web ui related)

@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 12, 2020
@nickvergessen
Copy link
Member

Well most of the issues suggest a value of 120, which we now have in 18.0.1 it was jsut not released yet

@blizzz
Copy link
Member Author

blizzz commented Feb 12, 2020

Well most of the issues suggest a value of 120, which we now have in 18.0.1 it was jsut not released yet

curl -Lm 0 --output /dev/null https://github.com/nextcloud/documentserver_community/releases/download/v0.1.5/documentserver_community.tar.gz 
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   622    0   622    0     0   1026      0 --:--:-- --:--:-- --:--:--  1026
100  301M  100  301M    0     0  2324k      0  0:02:12  0:02:12 --:--:-- 2994k

@nickvergessen
Copy link
Member

Yeah sure, just be aware people will still run into this from the web, but well don't care, continue

@blizzz
Copy link
Member Author

blizzz commented Feb 12, 2020

Yeah sure, just be aware people will still run into this from the web, but well don't care, continue

Yes, I discussed it with @rullzer earlier today, and agreed on doing the CLI change for now only.

@rullzer
Copy link
Member

rullzer commented Feb 12, 2020

Yeah from the CLI I'm fine. Poeple can then easily cancel it anyways.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz blizzz force-pushed the fix/17808/remove-timeout-appinstall branch from 0a66b43 to d06ef07 Compare February 12, 2020 15:53
@blizzz blizzz merged commit 6bf0c1f into master Feb 12, 2020
@blizzz blizzz deleted the fix/17808/remove-timeout-appinstall branch February 12, 2020 16:34
@backportbot-nextcloud
Copy link

backport to stable18 in #19439

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: apps management feature: occ
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants