optimize batch generation of previews #19495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview generator part is here nextcloud/previewgenerator#182 That's enough late night being angry at slow code for now 💤 |
|
ping... |
icewind1991
force-pushed
the
preview-generate-batch
branch
from
636b4b7
to
7094100
Compare
skjnldsv
approved these changes
Apr 9, 2020
this saves having to do some of the overhead multiple times Signed-off-by: Robin Appelman <robin@icewind.nl>
by allowing the generation of multiple previews at once we save on having to find, open and decode the max-preview for every preview of the same file the main use case for this is the preview generator app (pr for that comming next) in my local testing this saves about 25% of time when using the preview generator app Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
preview-generate-batch
branch
from
7b89239
to
7d38687
Compare
ChristophWurst
added
4. to release
|
Ci says nope: https://drone.nextcloud.com/nextcloud/server/27784/10/4 |
rullzer
added
2. developing
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
preview-generate-batch
branch
from
1388357
to
8f9bac2
Compare
This was referenced Aug 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by allowing the generation of multiple previews at once we save on having to find, open and decode the max-preview for every preview of the same file
the main use case for this is the preview generator app (pr for that coming next)
in my local testing this saves about 25% of time when using the preview generator app