Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix three dots menu on mobile devices #19541

Closed
wants to merge 1 commit into from
Closed

Fix three dots menu on mobile devices #19541

wants to merge 1 commit into from

Conversation

solracsf
Copy link
Member

@solracsf solracsf commented Feb 19, 2020

flex-wrap has no effect here.

Fixes #19479

image

@gary-kim gary-kim added 3. to review Waiting for reviews bug labels Feb 19, 2020
@gary-kim gary-kim added this to the Nextcloud 19 milestone Feb 19, 2020
@skjnldsv
Copy link
Member

Hey! :)

Well, grid doesn't make sense here as you're not specifying any grid layout :/

This was referenced Apr 4, 2020
This was referenced Apr 15, 2020
@MorrisJobke MorrisJobke changed the title Fix #19479 Fix three dots menu on mobile devices Apr 17, 2020
@rullzer rullzer mentioned this pull request Apr 23, 2020
11 tasks
@jancborchardt
Copy link
Member

Well, grid doesn't make sense here as you're not specifying any grid layout :/

What would be a more correct way for @acsfer to fix this in that case? :) (It does seem to fix the issue.)

jancborchardt
jancborchardt previously approved these changes Apr 23, 2020
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Design-wise this looks good, except that title and subline are a bit pushed down – they should be centered vertically in the header.

But needs further code feedback from @skjnldsv about what would be the right way to implement this.

@jancborchardt jancborchardt dismissed their stale review April 23, 2020 08:53

Accidentally approved

@solracsf
Copy link
Member Author

Can't dig into this in the next few days sorry. If @skjnldsv don't do, i'll do it next week.

@skjnldsv
Copy link
Member

flex-wrap has no effect here.

it have, the parent have a display inline-flex :)

@solracsf
Copy link
Member Author

Quick display from Firefox dev tools. ;)
image

@skjnldsv
Copy link
Member

Quick display from Firefox dev tools. ;)

Ah right, confused myself! Thanks for the help :)
So I think it used to be a flex, because we had the sharee name stacked here as well ?

The whole header should be a flex and the shrinkable area shuld only be the file name then, this is the expected behavior I think 🤔

Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replaced by #20744

@skjnldsv skjnldsv deleted the fix-19479 branch April 30, 2020 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Three dots menu not viewable on mobile browser in portrait view when longish file name used
5 participants