Remove gradient header for themed instances

[earboxer]

Close #19040 as suggested by @juliushaertl

[juliushaertl]

The plan was to keep the gradient for the default Nextcloud blue, but do not apply it if a custom theming color is set.

Adding a color check like

server/apps/theming/css/theming.scss

Line 15 in bf94acf

@if ($color-primary == #0082C9) or ($has-custom-background == true) {

to the main background fade mixin in

server/apps/theming/css/theming.scss

Line 11 in bf94acf

background-image: linear-gradient(40deg, $color-primary 0%, lighten($color-primary, 20%) 100%);

should do the trick.

[kesselb]

Gradients are so 1990 ...

[jancborchardt]

Agree with @juliushaertl, the gradient should only be removed when using a custom theming color.

And gradients being so 1990 makes them in fashion again now ;)

[bpcurse]

Milestone Nextcloud 19

Will this be backported to 18?

[earboxer]

I added the color check as described by @juliushaertl, but I haven't been able to test it...

What do we have to run on our servers to compile the SCSS? (and it's aware of the user-defined color at compile time?)

[rullzer]

@juliushaertl @jancborchardt good to go now?

[juliushaertl]

This breaks the default background image. That change should go to theming.scss. Maybe you can try something like this, to make sure that the gradient is properly set otherwise:

diff --git a/apps/theming/css/theming.scss b/apps/theming/css/theming.scss
index 0e9b922b27..c2a58dcc3d 100644
--- a/apps/theming/css/theming.scss
+++ b/apps/theming/css/theming.scss
@@ -8,7 +8,11 @@
 }
 
 @mixin faded-background {
-       background-image: linear-gradient(40deg, $color-primary 0%, lighten($color-primary, 20%) 100%);
+       @if ($color-primary == #0082C9) {
+               background-image: linear-gradient(40deg, $color-primary 0%, lighten($color-primary, 20%) 100%);
+       } @else {
+               background-color: $color-primary;
+       }
 }
 
 @mixin faded-background-image {
@@ -23,6 +27,10 @@
                @include faded-background;
                background-size: contain;
        }
+
+       @if ($color-primary != #0082C9) and ($has-custom-background == false) {
+               background-image: none;
+       }
 }

[juliushaertl]

What do we have to run on our servers to compile the SCSS? (and it's aware of the user-defined color at compile time?)

SCSS files should get reloaded automatically when debug mode is enabled. Otherwise you can always run occ maintenance:repair to remove all cached CSS.

[kesselb]

Conflicts after #20343.

[juliushaertl]

Thanks for getting this started. I've moved my suggestion to #21198 and did a bit of code cleanup in the same run as well so we can get this merged.