Enable fseek for files in S3 storage #20033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kesselb
reviewed
Mar 26, 2020
| */ | ||
| private static function registerIfNeeded() { | ||
| if (!self::$registered) { | ||
| stream_wrapper_register( |
There was a problem hiding this comment.
stream_wrapper_register() will return FALSE if the protocol already has a handler.
https://www.php.net/manual/en/function.stream-wrapper-register.php
Do we really need a state (registered y/no)? I guess stream_wrapper_register will not register more than one handler for one protocol.
rullzer
approved these changes
Apr 1, 2020
|
Needs a rebase |
Signed-off-by: Lukas Stabe <lukas@stabe.de>
Signed-off-by: Robin Appelman <robin@icewind.nl>
…return the wrong range Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
s3-seekable-stream
branch
from
c458bab
to
3ba46f3
Compare
kesselb
reviewed
Apr 1, 2020
|
@icewind1991 please address the comments and then lets get this in |
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
s3-seekable-stream
branch
from
b48013f
to
e22a28e
Compare
|
@rullzer @icewind1991 Do we want to backport this to 17 and 18? |
|
/backport to stable18 |
|
/backport to stable17 |
paulijar
added a commit
to paulijar/server
that referenced
this pull request
Sep 11, 2021
The PR nextcloud#20033 added support for `fseek` for the S3 storage backend. However, the seek mode SEEK_END was left out that time. This PR fills this gap. Signed-off-by: Pauli Järvinen <pauli.jarvinen@gmail.com>
backportbot-nextcloud bot
pushed a commit
that referenced
this pull request
Sep 20, 2021
The PR #20033 added support for `fseek` for the S3 storage backend. However, the seek mode SEEK_END was left out that time. This PR fills this gap. Signed-off-by: Pauli Järvinen <pauli.jarvinen@gmail.com>
backportbot-nextcloud bot
pushed a commit
that referenced
this pull request
Sep 20, 2021
The PR #20033 added support for `fseek` for the S3 storage backend. However, the seek mode SEEK_END was left out that time. This PR fills this gap. Signed-off-by: Pauli Järvinen <pauli.jarvinen@gmail.com>
backportbot-nextcloud bot
pushed a commit
that referenced
this pull request
Sep 20, 2021
The PR #20033 added support for `fseek` for the S3 storage backend. However, the seek mode SEEK_END was left out that time. This PR fills this gap. Signed-off-by: Pauli Järvinen <pauli.jarvinen@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the work of @ahti in #19073
Adjusted to be generic of any http stream where the server supports range requests so it's easy to extend to other storage backends in the future