Make sure group management works with all types of group names #20035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliushaertl
added
bug
3. to review
juliushaertl
force-pushed
the
bugfix/group-encode
branch
from
e231b38
to
19c90a7
Compare
|
Maybe add some phpunit testing? 🙈 |
|
Yeah, I'll do that. Anyone has concerns/ideas regarding the double encoding? |
|
Looks sane to me |
Not a fan but if it works...then great! |
juliushaertl
force-pushed
the
bugfix/group-encode
branch
from
19c90a7
to
57bb282
Compare
|
Added some test cases 😉 |
|
/backport to stable18 |
juliushaertl
force-pushed
the
bugfix/group-encode
branch
from
57bb282
to
8082a99
Compare
|
Rebased and ready for review. |
skjnldsv
approved these changes
Apr 9, 2020
GretaD
force-pushed
the
bugfix/group-encode
branch
from
57be87e
to
7811c8d
Compare
juliushaertl
force-pushed
the
bugfix/group-encode
branch
2 times, most recently
from
ccea55c
to
3ec9a01
Compare
blizzz
added
4. to release
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
skjnldsv
force-pushed
the
bugfix/group-encode
branch
from
3ec9a01
to
db90023
Compare
|
/compile amend / |
Signed-off-by: Julius Härtl <jus@bitgrid.net> Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
npmbuildbot-nextcloud
bot
force-pushed
the
bugfix/group-encode
branch
from
db90023
to
c20321e
Compare
|
backport to stable18 in #20433 with conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Group ids currently don't have any character limitations, which means that you can create groups like "Department A/B" which will fail on both the provisioning API as well as the routes provided by our user management.
This PR ensures that all group ids are encoded and properly handled by both the backend and the frontend then.
I'm not to happy about the double encoding here, but this is the only way that we can keep the groupId as part of the URL without making it a query parameter and therefore breaking the provisioning api.
In general I would prefer to add some character limitation to the group id, similar to how we do it for the user id, where
/is blocked, but that would still leave us with instances that might have those broken ids.