Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix mail template #20118

Closed
wants to merge 1 commit into from
Closed

fix mail template #20118

wants to merge 1 commit into from

Conversation

mkofahl
Copy link

@mkofahl mkofahl commented Mar 23, 2020

Mail clients may hide the content if the table showing the logo is at 100% height.

@gary-kim
Copy link
Member

gary-kim commented Mar 23, 2020

Thank you for your contribution!

Could you add a DCO to your commit? The easiest way would be to add the -s flag from the command line. You can run the following command to add a DCO from the head of your commit: git commit -s --amend then git push --force-with-lease.
Otherwise, you can also add the following to the bottom of your commit message.

Signed-off-by: Random J Developer <random@developer.example.org>

@nickvergessen
Copy link
Member

@mkofahl any specific client you had a problem with?

@mkofahl
Copy link
Author

mkofahl commented Mar 27, 2020

@mkofahl any specific client you had a problem with?

Yes, Zimbra.

Mail clients may hide the content if the table showing the logo is at 100% height.

Signed-off-by: Martin Kofahl <martin.kofahl@gmail.com>
This was referenced Apr 4, 2020
This was referenced Apr 15, 2020
@rullzer rullzer mentioned this pull request Apr 23, 2020
11 tasks
@rullzer rullzer removed this from the Nextcloud 19 milestone Apr 30, 2020
@MorrisJobke
Copy link
Member

@jancborchardt @skjnldsv Do you think this is okay CSS-wise?

@skjnldsv
Copy link
Member

@mkofahl can you post before/after screenshotsplease, we usually like to have direct comparison on design pull requests!
Thanks for your work!! 🚀

@skjnldsv skjnldsv added design Design, UI, UX, etc. feature: emails labels Jul 14, 2020
@J0WI
Copy link
Contributor

J0WI commented Apr 28, 2021

ping @mkofahl

@J0WI J0WI added the stale Ticket or PR with no recent activity label Apr 28, 2021
@MorrisJobke
Copy link
Member

Let's close it as we can reopen it at any time anyways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug design Design, UI, UX, etc. feature: emails stale Ticket or PR with no recent activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants