Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default titles for titleless events in invitations #20188

Merged
merged 1 commit into from
Apr 7, 2020
Merged

Add default titles for titleless events in invitations #20188

merged 1 commit into from
Apr 7, 2020

Conversation

tcitworld
Copy link
Member

Closes #19662

@tcitworld tcitworld added 3. to review Waiting for reviews feature: dav labels Mar 26, 2020
@tcitworld tcitworld added this to In progress in Thomas things to do via automation Mar 26, 2020
@tcitworld tcitworld added this to the Nextcloud 19 milestone Mar 26, 2020
@tcitworld tcitworld requested a review from rullzer March 26, 2020 17:34
Thomas things to do automation moved this from In progress to Review in progress Mar 26, 2020
@tcitworld tcitworld force-pushed the bug/19662/add-default-title-for-event-in-invitatios branch from 558b36d to f81fe8b Compare March 26, 2020 17:39
ChristophWurst
ChristophWurst previously requested changes Apr 3, 2020
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your indentation seems off, the rest looks good :)

@tcitworld
Add default titles for titleless events in invitations
058ffa3 
Closes #19662

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
@tcitworld tcitworld force-pushed the bug/19662/add-default-title-for-event-in-invitatios branch from f81fe8b to 058ffa3 Compare April 3, 2020 11:49
Thomas things to do automation moved this from Review in progress to Reviewer approved Apr 3, 2020
@rullzer rullzer mentioned this pull request Apr 4, 2020
Merged
80 tasks
@rullzer rullzer merged commit e266666 into master Apr 7, 2020
Thomas things to do automation moved this from Reviewer approved to Done Apr 7, 2020
@rullzer rullzer deleted the bug/19662/add-default-title-for-event-in-invitatios branch April 7, 2020 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgehrke georgehrke georgehrke approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@rullzer rullzer Awaiting requested review from rullzer

@juliushaertl juliushaertl Awaiting requested review from juliushaertl

Assignees
No one assigned
Labels
3. to review Waiting for reviews feature: dav
Projects
No open projects
Thomas things to do
  
Done
Milestone
Nextcloud 19
Development

Successfully merging this pull request may close these issues.

Event email invitations have no default title for titleless events
4 participants
@tcitworld @georgehrke @ChristophWurst @rullzer