Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to navigate to others with access from the sidebar #20262

Merged
merged 1 commit into from
Apr 29, 2020
Merged

Allow to navigate to others with access from the sidebar #20262

merged 1 commit into from
Apr 29, 2020

Conversation

rullzer
Copy link
Member

@rullzer rullzer commented Apr 1, 2020

Signed-off-by: Roeland Jago Douma roeland@famdouma.nl

rullzer
rullzer commented Apr 2, 2020
View reviewed changes
apps/files_sharing/lib/Controller/ShareAPIController.php
@@ -851,8 +851,11 @@ public function getInheritedShares(string $path): DataResponse {
throw new OCSNotFoundException($this->l->t('Could not lock path'));
}

if (!($node->getPermissions() & Constants::PERMISSION_SHARE)) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daita any reason you didn't just go with this check?
I'm asking since your confirmresharingrights doesn't work if you and in the sub sub folder of a share.

@rullzer rullzer added this to the Nextcloud 19 milestone Apr 2, 2020
@rullzer rullzer added the 3. to review Waiting for reviews label Apr 2, 2020
This was referenced Apr 4, 2020
Merged
Merged
This was referenced Apr 15, 2020
Merged
Merged
@rullzer rullzer mentioned this pull request Apr 23, 2020
Merged
11 tasks
@rullzer rullzer force-pushed the fix/others_with_acces/navigation branch from 6e38185 to 25907e2 Compare April 29, 2020 09:56
@rullzer
Copy link
Member Author

rullzer commented Apr 29, 2020

/compile amend /

@rullzer
Copy link
Member Author

rullzer commented Apr 29, 2020

To review

  1. Create a bunch of users, user1 user2 user3 user4 user5
  2. user1 creates a folder dep1 and shares it to user 2
  3. user2 creates dep2 in dep1 and shares it to user3 and user 4
  4. user4 creates dep3 in dep2 and shares it to user5
  5. user5 creates dep4 in dep3

Now for example login as user3.
And check the others with access on dep4
You should see the other users. And be able to see what the most common path is both of you have access to.

skjnldsv
skjnldsv approved these changes Apr 29, 2020
View reviewed changes
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@georgehrke
Copy link
Member

Master This PR
F70F608E-0168-4DB4-9BBE-FC47CB5B45B8 E586B2C3-B7A0-4762-BAC3-CAF7ED86FBF6

@georgehrke
Copy link
Member

@rullzer Is there a separate issue that it doesn't display user1?

@skjnldsv
Copy link
Member

@rullzer Is there a separate issue that it doesn't display user1?

Yes, I mentionned it to Roeland already :)

@rullzer
Copy link
Member Author

rullzer commented Apr 29, 2020

Right I gues we need to fix that separately yes... But let me first rebase this and get it in and then I look at that case

@rullzer rullzer force-pushed the fix/others_with_acces/navigation branch from 25907e2 to 3eb2e9b Compare April 29, 2020 17:42
@rullzer
Copy link
Member Author

rullzer commented Apr 29, 2020

/compile amend /

@rullzer @npmbuildbot
Allow to navigate to others with access from the sidebar
d466a7b 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
@npmbuildbot-nextcloud npmbuildbot-nextcloud bot force-pushed the fix/others_with_acces/navigation branch from 3eb2e9b to d466a7b Compare April 29, 2020 17:53
@rullzer rullzer merged commit 8247576 into master Apr 29, 2020
@rullzer rullzer deleted the fix/others_with_acces/navigation branch April 29, 2020 19:32
@backportbot-nextcloud
Copy link

The backport to review failed. Please do this backport manually.

@rullzer
Copy link
Member Author

rullzer commented Apr 30, 2020

/backport to stable18

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Apr 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgehrke georgehrke georgehrke approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@wiswedel wiswedel Awaiting requested review from wiswedel

@juliushaertl juliushaertl Awaiting requested review from juliushaertl

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

Assignees
No one assigned
Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 19
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rullzer @georgehrke @skjnldsv