Array offset error due to empty file versions array #20449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rray Signed-off-by: Liam JACK <liamjack@users.noreply.github.com>
|
Thanks for your time 👍 I'm still not sure if having no version is a valid state but the fix will prevent the error :) |
This was referenced Apr 13, 2020
Merged
Merged
Merged
MorrisJobke
changed the title
rullzer
requested review from
ChristophWurst,
MorrisJobke,
nickvergessen and
juliushaertl
ChristophWurst
approved these changes
Apr 17, 2020
ChristophWurst
added
4. to release
|
/backport to stable18 |
|
/backport to stable17 |
|
backport to stable18 in #20578 with conflicts |
|
backport to stable17 in #20579 with conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #19066 implementing fix proposed by @kesselb (#19066 (comment))