Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly display share error messages #20469

Merged
merged 1 commit into from
Apr 14, 2020

Conversation

skjnldsv
Copy link
Member

Fix #19525
image

@skjnldsv skjnldsv added bug design Design, UI, UX, etc. 3. to review Waiting for reviews feature: sharing feature: file sidebar Related to the file sidebar component 18-feedback labels Apr 14, 2020
@skjnldsv skjnldsv added this to the Nextcloud 19 milestone Apr 14, 2020
@skjnldsv skjnldsv self-assigned this Apr 14, 2020
@skjnldsv
Copy link
Member Author

/backport to stable18

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 14, 2020
@skjnldsv
Copy link
Member Author

/compile amend /

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
@npmbuildbot-nextcloud npmbuildbot-nextcloud bot force-pushed the fix/sidebar/sharing/password-error-message branch from 8766eff to 47146a1 Compare April 14, 2020 08:39
@skjnldsv skjnldsv merged commit e4d378d into master Apr 14, 2020
@skjnldsv skjnldsv deleted the fix/sidebar/sharing/password-error-message branch April 14, 2020 09:25
@backportbot-nextcloud
Copy link

backport to stable18 in #20471 with conflicts ⚠️

@rullzer rullzer mentioned this pull request Apr 15, 2020
59 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug design Design, UI, UX, etc. feature: file sidebar Related to the file sidebar component feature: sharing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

counterintuitive error message when password to share does not conform to policy
3 participants