DAV's exception logger should deal with any Throwable #20503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
blizzz
requested review from
rullzer,
nickvergessen,
ChristophWurst and
skjnldsv
nickvergessen
approved these changes
Apr 15, 2020
ChristophWurst
approved these changes
Apr 15, 2020
|
cs fixer complains about unrelated files, can be ignored in this context |
blizzz
added
4. to release
georgehrke
approved these changes
Apr 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was having an occasion where a TypeError was passed in via sabre's WildcardEmitterTrait
"Exception": "TypeError", "Message": "Argument 1 passed to OCA\\DAV\\Connector\\Sabre\\ExceptionLoggerPlugin::logException() must be an instance of Exception, instance of TypeError given, called in /srv/http/nextcloud/master/3rdparty/sabre/event/lib/WildcardEmitterTrait.php on line 89",