do not advertise nulled userId for for systemwide credentials #20505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
these are actually expected to FAIL, because NULL as a userid is not allowed in the schema, but documented to be used on the source Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
…string Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
blizzz
requested review from
rullzer,
nickvergessen,
skjnldsv,
juliushaertl and
ChristophWurst
blizzz
added
3. to review
ChristophWurst
approved these changes
Apr 15, 2020
skjnldsv
approved these changes
Apr 15, 2020
|
/backport to stable18 |
|
/backport to stable17 |
|
/backport to stable16 |
This was referenced Apr 15, 2020
Merged
Merged
Merged
|
backport to stable18 in #20516 |
|
backport to stable17 in #20517 |
|
backport to stable16 in #20518 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
these (first commit) are actually expected to FAIL, because NULL as a userid is not
allowed in the schema, but documented to be used on the source.
There you go:
I will push fixing commits after CI finished.
I left the API as is for compatibility (although it probably would have crashed earlier if someone was using it…). Now it is de-facto backwards compatible and uses strings against DB always.