Show changelog in apps management #21082

juliushaertl · 2020-05-24T14:37:43Z

This will use the changelog provided by the most recent app store release and show it in the apps management sidebar if available.

Besides that I also did some code cleanup, migrated to use the new sidebar tabs for description/changelog and removed the list transition which had quite a negative performance impact when searching and switching between app categories.

With a changelog:

Without a changelog:

jancborchardt · 2020-05-24T15:24:20Z

Very nice! Only minor thing is that we should call it "What’s new" instead of "Changelog" which is a bit bland and technical. :)

GretaD

tested and works

jancborchardt

See comment for wording change (I would add it directly but somehow often the build process for the apps in core messes stuff up for me).

rullzer · 2020-06-06T07:39:15Z

needs a rebase and the comment from @jancborchardt addressed

juliushaertl · 2020-07-09T18:49:56Z

I'll wait for #18969 with the rebase since I forgot that @skjnldsv was already worked on the sidebar migration. Once that is done I'll just pick the relevant changelog changes.

skjnldsv · 2020-07-09T21:20:42Z

I'll wait for #18969 with the rebase since I forgot that @skjnldsv was already worked on the sidebar migration. Once that is done I'll just pick the relevant changelog changes.

Thanks! 🙇 ❤️

jancborchardt · 2020-07-28T21:40:44Z

Btw @juliushaertl to make it simpler and also work better on mobile, we could just put the changelog below the description/links instead of using tabs.

This is also how the Android Play store and the iOS app store essentially do it. To alleviate the case of a very long description, we can set some max-height which will expand on click – exactly like we do for the rich workspaces.

rullzer · 2020-08-13T03:33:22Z

@juliushaertl still something we can tackle for 20?

juliushaertl · 2020-08-13T06:15:05Z

Not before #18969

skjnldsv · 2020-08-13T07:38:52Z

Not before #18969

will dive into it again soon

rullzer · 2020-08-20T13:01:44Z

soooo?

juliushaertl · 2020-09-01T10:10:34Z

Force-pushed the changelog only changes now based on master.

faily-bot · 2020-09-01T11:01:16Z

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 32532: failure

jsunit

Show full log

PhantomJS 2.1.1 (Linux 0.0.0) WARN: 'No OC found'
PhantomJS 2.1.1 (Linux 0.0.0) LOG: 'JQMIGRATE: Migrate is installed, version 1.4.1'
PhantomJS 2.1.1 (Linux 0.0.0) WARN: 'jQuery is deprecated: The global jQuery is deprecated. It will be updated to v3.x in Nextcloud 21. In later versions of Nextcloud it might be removed completely. Please ship your own.'
PhantomJS 2.1.1 (Linux 0.0.0) WARN: '$ is deprecated: The global jQuery is deprecated. It will be updated to v3.x in Nextcloud 21. In later versions of Nextcloud it might be removed completely. Please ship your own.'
PhantomJS 2.1.1 (Linux 0.0.0) WARN: 'Handlebars is deprecated: please ship your own, this will be removed in Nextcloud 20'
PhantomJS 2.1.1 (Linux 0.0.0) DEBUG: 'OCA.Files.Settings initialized'
PhantomJS 2.1.1 (Linux 0.0.0) DEBUG: 'OCA.Files.Sidebar initialized'
PhantomJS 2.1.1 (Linux 0.0.0) DEBUG: 'OCA.Sharing.ShareSearch initialized'
PhantomJS 2.1.1 (Linux 0.0.0) DEBUG: 'OCA.Sharing.ExternalLinkActions initialized'
PhantomJS 2.1.1 (Linux 0.0.0): Executed 847 of 850 (skipped 3) SUCCESS (14.094 secs / 13.473 secs)

mariadb10.1-php7.2

Show full log

There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) OCA\DAV\Tests\unit\CardDAV\CardDavBackendTest::testSearch with data set "case insensitive" ('john', array('FN'), array(), array(array('uri0', 'John Doe'), array('uri1', 'John M. Doe')))
Failed asserting that 1 is identical to 2.

/drone/src/apps/dav/tests/unit/CardDAV/CardDavBackendTest.php:746

mariadb10.4-php7.3

Show full log

There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) Test\Share20\DefaultShareProviderTest::testGroupDeleted with data set #1 (array(0, 'user', array()), 'user', false)
Failed asserting that actual size 0 matches expected size 1.

/drone/src/tests/lib/Share20/DefaultShareProviderTest.php:2418

apps/settings/src/components/Markdown.vue

skjnldsv · 2020-09-01T11:45:53Z

apps/settings/src/views/Apps.vue

+				<AppDetails :app="app" />
+			</AppSidebarTab>
+			<AppSidebarTab v-if="app.appstoreData && app.releases[0].translations.en.changelog"
+				id="desca"


desca ?

Suggested change

id="desca"

id="changelog"

skjnldsv

Minor nitpick! :)
Great job!!! 🚀 😍

rullzer · 2020-09-03T19:03:14Z

/compile amend /

Signed-off-by: Julius Härtl <jus@bitgrid.net> Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>

juliushaertl added enhancement 3. to review Waiting for reviews labels May 24, 2020

juliushaertl added this to the Nextcloud 20 milestone May 24, 2020

juliushaertl requested review from rullzer, jancborchardt, ChristophWurst, GretaD and skjnldsv May 24, 2020 14:37

juliushaertl added the feature: apps management label May 24, 2020

GretaD approved these changes May 25, 2020

View reviewed changes

jancborchardt requested changes May 25, 2020

View reviewed changes

MorrisJobke mentioned this pull request Aug 11, 2020

20.0.0 Beta 1 #22188

Merged

57 tasks

juliushaertl mentioned this pull request Aug 14, 2020

Migrate app management settings to proper sidebar standards #18969

Merged

skjnldsv added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Aug 20, 2020

rullzer mentioned this pull request Aug 21, 2020

20 Beta 2 #22352

Merged

19 tasks

kesselb linked an issue Aug 26, 2020 that may be closed by this pull request

Feature Req: Show change logs for app updates #22436

Closed

rullzer mentioned this pull request Aug 27, 2020

20 Beta3 #22455

Merged

21 tasks

juliushaertl force-pushed the enh/noid/apps-settings branch from 13fb014 to dc3c146 Compare September 1, 2020 10:10

juliushaertl removed the 2. developing Work in progress label Sep 1, 2020

juliushaertl added the 3. to review Waiting for reviews label Sep 1, 2020

skjnldsv reviewed Sep 1, 2020

View reviewed changes

apps/settings/src/components/Markdown.vue Show resolved Hide resolved

skjnldsv reviewed Sep 1, 2020

View reviewed changes

skjnldsv approved these changes Sep 1, 2020

View reviewed changes

skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 1, 2020

rullzer mentioned this pull request Sep 3, 2020

20 beta 4 #22562

Merged

13 tasks

rullzer force-pushed the enh/noid/apps-settings branch from dc3c146 to eca1c19 Compare September 3, 2020 19:03

Show changelog in apps management

7a1748e

Signed-off-by: Julius Härtl <jus@bitgrid.net> Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>

npmbuildbot-nextcloud bot force-pushed the enh/noid/apps-settings branch from eca1c19 to 7a1748e Compare September 3, 2020 19:16

rullzer merged commit c205fac into master Sep 3, 2020

rullzer deleted the enh/noid/apps-settings branch September 3, 2020 20:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Show changelog in apps management #21082

Show changelog in apps management #21082

juliushaertl commented May 24, 2020

jancborchardt commented May 24, 2020

GretaD left a comment

jancborchardt left a comment •

edited

Loading

rullzer commented Jun 6, 2020

juliushaertl commented Jul 9, 2020

skjnldsv commented Jul 9, 2020

jancborchardt commented Jul 28, 2020

rullzer commented Aug 13, 2020

juliushaertl commented Aug 13, 2020

skjnldsv commented Aug 13, 2020

rullzer commented Aug 20, 2020

juliushaertl commented Sep 1, 2020

faily-bot bot commented Sep 1, 2020

skjnldsv Sep 1, 2020

skjnldsv left a comment

rullzer commented Sep 3, 2020

Show changelog in apps management #21082

Show changelog in apps management #21082

Conversation

juliushaertl commented May 24, 2020

jancborchardt commented May 24, 2020

GretaD left a comment

Choose a reason for hiding this comment

jancborchardt left a comment • edited Loading

Choose a reason for hiding this comment

rullzer commented Jun 6, 2020

juliushaertl commented Jul 9, 2020

skjnldsv commented Jul 9, 2020

jancborchardt commented Jul 28, 2020

rullzer commented Aug 13, 2020

juliushaertl commented Aug 13, 2020

skjnldsv commented Aug 13, 2020

rullzer commented Aug 20, 2020

juliushaertl commented Sep 1, 2020

faily-bot bot commented Sep 1, 2020

Status of 32532: failure

jsunit

mariadb10.1-php7.2

mariadb10.4-php7.3

skjnldsv Sep 1, 2020

Choose a reason for hiding this comment

skjnldsv left a comment

Choose a reason for hiding this comment

rullzer commented Sep 3, 2020

jancborchardt left a comment •

edited

Loading