Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix obsolete usage of OCdialogs #21564

Merged
merged 1 commit into from Jun 24, 2020
Merged

fix obsolete usage of OCdialogs #21564

merged 1 commit into from Jun 24, 2020

Conversation

blizzz
Copy link
Member

@blizzz blizzz commented Jun 24, 2020 •
edited

to reproduce:

  1. in LDAP Wizard fill in the basics of a new connection and tick the last checkbox ("Manually enter LDAP filters")
  2. Go to the next tab
  3. Try to switch away from manual to the assisted mode

What happens:

  • nothing, and in the browser console that OCdialogs is undefined
  • actually saw this on 18

Expected is a confirmation dialog (to avoid long runnning ops against big LDAPs)

Background: #15339

@blizzz
fix obsolete usage of OCdialogs
b71f52f 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz blizzz added this to the Nextcloud 20 milestone Jun 24, 2020
@blizzz
Copy link
Member Author

blizzz commented Jun 24, 2020

/backport to stable19

@blizzz
Copy link
Member Author

blizzz commented Jun 24, 2020

/backport to stable18

@blizzz
Copy link
Member Author

blizzz commented Jun 24, 2020

/backport to stable17

@blizzz blizzz merged commit 30e9993 into master Jun 24, 2020
@blizzz blizzz deleted the fix/noid/no-ocdialogs branch June 24, 2020 16:58
This was referenced Jun 24, 2020
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer rullzer approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@georgehrke georgehrke Awaiting requested review from georgehrke

@juliushaertl juliushaertl Awaiting requested review from juliushaertl

@pixelipo pixelipo Awaiting requested review from pixelipo

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug feature: ldap
Projects
None yet
Milestone
Nextcloud 20
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@blizzz @rullzer @ChristophWurst