Precalculate the primary element color for dark mode too #21594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
added
enhancement
3. to review
nickvergessen
requested review from
AndyScherzinger,
ChristophWurst,
juliushaertl and
tobiasKaminsky
tobiasKaminsky
approved these changes
Jun 26, 2020
ChristophWurst
added
the
4. to release
juliushaertl
approved these changes
Jun 26, 2020
Signed-off-by: Joas Schilling <coding@schilljs.com>
|
I guess backport is appriciated |
|
I guess so, while @tobiasKaminsky might know best if we can handle that nicely :) |
|
Backport would be great, then we can assume to have it on >= 19.x 👍 |
|
/backport to stable19 |
nickvergessen
deleted the
bugfix/21586/precalculate-primary-element-color-for-dark-mode-too
branch
This was referenced Jul 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #21586