contactsmanager shall limit number of results early #22057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blizzz
added
bug
3. to review
blizzz
requested review from
MorrisJobke,
georgehrke,
LEDfan,
juliushaertl and
skjnldsv
|
/backport to stable19 |
blizzz
requested review from
ChristophWurst
and removed request for
ChristophWurst
blizzz
force-pushed
the
fix/20009/contactsmenu-limit-users
branch
from
7828a92
to
646820b
Compare
MorrisJobke
reviewed
Jul 30, 2020
MorrisJobke
requested changes
Jul 30, 2020
georgehrke
reviewed
Jul 30, 2020
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
blizzz
force-pushed
the
fix/20009/contactsmenu-limit-users
branch
from
646820b
to
7c56283
Compare
MorrisJobke
approved these changes
Jul 31, 2020
This comment has been minimized.
This comment has been minimized.
nickvergessen
approved these changes
Aug 3, 2020
|
/backport to stable18 |
The limit is passed down, but not the sort order. So the result correctness is only given if database sorts the same way as the PHP code does later on. Let's say you have 100 contacts. The database sorts them by UID. You select the first 20 rows, then sort the rows by name. It's not the same result as fetching all 100 contacts, sorting them and then taking the first 20 entries.
|
|
You have (still) too many results 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #20009 cf. #20009 (comment)
Optional arguments are added to the ContactsStore API, so it should be okay to backport it to 19. Support for limiting results is implemented down the stack already. Since the contactsmenu reduces results according to
sharing.maxAutocompleteResultsand the search filter is passed to the backend, limiting the possible results up front does not sacrifice anything, but improves performance.