Make apps handle the order logic #22104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skjnldsv
requested review from
nickvergessen,
MorrisJobke,
georgehrke and
juliushaertl
skjnldsv
commented
Aug 4, 2020
skjnldsv
force-pushed
the
fix/unified-search
branch
from
2cb8704
to
7aa61af
Compare
skjnldsv
force-pushed
the
enh/search/make-app-handle-the-order-logic
branch
3 times, most recently
from
29865a8
to
7d6a904
Compare
skjnldsv
force-pushed
the
fix/unified-search
branch
2 times, most recently
from
0af7698
to
71b62c4
Compare
skjnldsv
force-pushed
the
enh/search/make-app-handle-the-order-logic
branch
2 times, most recently
from
0e312c0
to
e97e34d
Compare
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
skjnldsv
force-pushed
the
enh/search/make-app-handle-the-order-logic
branch
from
1bb706c
to
38621f2
Compare
skjnldsv
added
3. to review
|
Done, let's wait for #22099 to me merged |
|
/compile amend / |
|
Ready to review, compile bot incoming! 🚀 |
Signed-off-by: Joas Schilling <coding@schilljs.com> Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
npmbuildbot-nextcloud
bot
force-pushed
the
enh/search/make-app-handle-the-order-logic
branch
from
38621f2
to
ea8f68b
Compare
|
All green 💚 |
Except for the second approval 😝 |
I'm trying to lure some people here 😭 |
nickvergessen
approved these changes
Aug 5, 2020
|
🤗 |
skjnldsv
added
4. to release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let the app return a lower order if the url matches its requirements!
Will be cleaner than checking against a weird id!