Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable18] shortcut in reading nested group members when IN_CHAIN is available #22204

Merged
merged 3 commits into from Aug 12, 2020

Conversation

backportbot-nextcloud[bot]
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Aug 11, 2020

⚠️ This backport had conflicts and is incomplete ⚠️

backport of #21559

…able

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
- the detection relies that the first, requested result is not empty
- it might be empty though – groups without members
- protect switching from available to unavailable
  - switching the other way around was also not envisaged either

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@MorrisJobke
Copy link
Member

CI fails

@MorrisJobke MorrisJobke added the 3. to review Waiting for reviews label Aug 12, 2020
@blizzz
Copy link
Member

blizzz commented Aug 12, 2020

CI fails

same similar as in 19. pushing in a two moments.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz blizzz added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 12, 2020
@faily-bot
Copy link

faily-bot bot commented Aug 12, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 31705: failure

mysql5.6-php7.2

Show full log
There was 1 error:

1) OCA\ShareByMail\Tests\ShareByMailProviderTest::testGetAccessList
OCP\Share\Exceptions\ShareNotFound: There was an error retrieving the share. Maybe the link is wrong, it was unshared, or it was deleted.

/drone/src/apps/sharebymail/lib/ShareByMailProvider.php:1121
/drone/src/apps/sharebymail/lib/ShareByMailProvider.php:206
/drone/src/apps/sharebymail/tests/ShareByMailProviderTest.php:1019

--

There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

acceptance-app-files

  • tests/acceptance/features/app-files.feature:108
Show full log
  Scenario: show shares                                               # /drone/src/tests/acceptance/features/app-files.feature:108
    Given I am logged in                                              # LoginPageContext::iAmLoggedIn()
    And I share the link for "welcome.txt"                            # FilesAppSharingContext::iShareTheLinkFor()
    When I open the "Shares" section                                  # AppNavigationContext::iOpenTheSection()
    Then I see that the current section is "Shares"                   # AppNavigationContext::iSeeThatTheCurrentSectionIs()
    Then I see that the file list contains a file named "welcome.txt" # FileListContext::iSeeThatTheFileListContainsAFileNamed()
      Row for file welcome.txt in file list could not be found after 100 seconds (NoSuchElementException)

@MorrisJobke MorrisJobke merged commit e322653 into stable18 Aug 12, 2020
@MorrisJobke MorrisJobke deleted the backport/21559/stable18 branch August 12, 2020 20:55
@rullzer rullzer mentioned this pull request Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug enhancement feature: ldap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants