re-index contacts with social profiles #22222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
call-me-matt
commented
Aug 15, 2020
nickvergessen
requested changes
Aug 19, 2020
| ->andWhere($query->expr()->lte('c.id', $query->createNamedParameter($stopAt))) | ||
| ->andWhere($query->expr()->gt('c.id', $query->createNamedParameter($offset))) | ||
| ->orderBy('c.id', 'ASC'); | ||
| $social_cards = $query->execute(); |
There was a problem hiding this comment.
Need a limit on this query and then loop the execution with different offsets instead.
There was a problem hiding this comment.
What do you mean? Currently it stops after 15sec and schedules a follow-up. Or do you think this query could take too much memory?
There was a problem hiding this comment.
if you have 10k users you load 100k entries from the database, that's going to take a while and eat lots of memory, yeah.
There was a problem hiding this comment.
I would expect a deployment of that size to have enough memory for such a query. Or did you experience problems when executing these kind of tasks in past, for example here?
There was a problem hiding this comment.
Fix is in #22311
Well this is also about contacts, not only users, so it can explode rather quickly in size, so better to be save than having people with bug reports on update.
There was a problem hiding this comment.
Yes, better safe than sorry... I have pushed an update, can you check? It's limiting the query, but if there are thousands of users there will be many background jobs to work off anyways. I am particularly interested, because I have introduced a way more demanding background job in nextcloud/contacts#1745
call-me-matt
commented
Aug 19, 2020
call-me-matt
commented
Aug 20, 2020
| $query = $this->db->getQueryBuilder(); | ||
| // TODO: return contacts with multiple social profiles only once | ||
| // FIXME: distinct seems only to return the first parameter? | ||
| // $query->selectDistinct('c.addressbookid', 'c.uri', 'c.carddata') |
There was a problem hiding this comment.
any idea how the distinct query can be applied here?
There was a problem hiding this comment.
Why do you want to distinct? We need to update all entries?
Suggested change
| // $query->selectDistinct('c.addressbookid', 'c.uri', 'c.carddata') | |
| $query->select('c.addressbookid', 'c.uri', 'c.carddata') | |
| ->selectDistinct('c.id') |
but since its the id column you dont select duplicates anyway, so should be fine without it.
There was a problem hiding this comment.
Well, I am looking in the cards_properties for socialprofiles and then take the respective contacts from cards (so that I have only the ones with social profiles). But thinking about that now again, I guess the card-properties are in fact the indexed parameters, so that I cannot search in there and must take all contacts?
There was a problem hiding this comment.
I have changed that now, see 69f3dca
|
The autoloaders are not up to date |
What exactly do I need to do? Filelist
But the output is not very convincing. I seems to be trapped in a loop? $ bash build/autoloaderchecker.shComposer found: checking for update
A preview release of the next major version of Composer is available (2.0.0-RC1), run "composer self-update --preview" to give it a try. See also https://github.com/composer/composer/releases for changelogs.
You are already using composer version 1.10.13 (stable channel).
Regenerating main autoloader
Generating optimized autoload files
Generated optimized autoload files containing 1306 classes
Regenerating autoloader for /var/www/nextcloud/apps/accessibility
Generating optimized autoload files (authoritative)
Generated optimized autoload files (authoritative) containing 7 classes
Regenerating autoloader for /var/www/nextcloud/apps/admin_audit
Generating optimized autoload files (authoritative)
Generated optimized autoload files (authoritative) containing 13 classes
Regenerating autoloader for /var/www/nextcloud/apps/cloud_federation_api
Generating optimized autoload files (authoritative)
Generated optimized autoload files (authoritative) containing 4 classes
Regenerating autoloader for /var/www/nextcloud/apps/comments
Generating optimized autoload files (authoritative)
Generated optimized autoload files (authoritative) containing 15 classes
Regenerating autoloader for /var/www/nextcloud/apps/contactsinteraction
Generating optimized autoload files (authoritative)
Generated optimized autoload files (authoritative) containing 10 classes
Regenerating autoloader for /var/www/nextcloud/apps/dav
Generating optimized autoload files (authoritative)
Generated optimized autoload files (authoritative) containing 223 classes
Regenerating autoloader for /var/www/nextcloud/apps/encryption
Generating optimized autoload files (authoritative)
Generated optimized autoload files (authoritative) containing 26 classes
Regenerating autoloader for /var/www/nextcloud/apps/federatedfilesharing
Generating optimized autoload files (authoritative)
Deprecation Notice: Class OCA\FederatedFileSharing\OCM\CloudFederationProviderFiles located in /var/www/nextcloud/apps/federatedfilesharing/lib/ocm/CloudFederationProviderFiles.php does not comply with psr-4 autoloading standard. It will not autoload anymore in Composer v2.0. in phar:///var/www/nextcloud/composer.phar/src/Composer/Autoload/ClassMapGenerator.php:201
Generated optimized autoload files (authoritative) containing 13 classes
Regenerating autoloader for /var/www/nextcloud/apps/federation
Generating optimized autoload files (authoritative)
Generated optimized autoload files (authoritative) containing 14 classes
Regenerating autoloader for /var/www/nextcloud/apps/files
Generating optimized autoload files (authoritative)
Generated optimized autoload files (authoritative) containing 45 classes
Regenerating autoloader for /var/www/nextcloud/apps/files_sharing
Generating optimized autoload files (authoritative)
Generated optimized autoload files (authoritative) containing 63 classes
Regenerating autoloader for /var/www/nextcloud/apps/files_trashbin
Generating optimized autoload files (authoritative)
Generated optimized autoload files (authoritative) containing 34 classes
Regenerating autoloader for /var/www/nextcloud/apps/files_versions
Generating optimized autoload files (authoritative)
Generated optimized autoload files (authoritative) containing 27 classes
Regenerating autoloader for /var/www/nextcloud/apps/lookup_server_connector
Generating optimized autoload files (authoritative)
Generated optimized autoload files (authoritative) containing 3 classes
Regenerating autoloader for /var/www/nextcloud/apps/oauth2
Generating optimized autoload files (authoritative)
Generated optimized autoload files (authoritative) containing 13 classes
Regenerating autoloader for /var/www/nextcloud/apps/provisioning_api
Generating optimized autoload files (authoritative)
Generated optimized autoload files (authoritative) containing 9 classes
Regenerating autoloader for /var/www/nextcloud/apps/settings
Generating optimized autoload files (authoritative)
Generated optimized autoload files (authoritative) containing 47 classes
Regenerating autoloader for /var/www/nextcloud/apps/sharebymail
Generating optimized autoload files (authoritative)
Generated optimized autoload files (authoritative) containing 7 classes
Regenerating autoloader for /var/www/nextcloud/apps/systemtags
Generating optimized autoload files (authoritative)
Generated optimized autoload files (authoritative) containing 5 classes
Regenerating autoloader for /var/www/nextcloud/apps/testing
Generating optimized autoload files (authoritative)
Generated optimized autoload files (authoritative) containing 6 classes
Regenerating autoloader for /var/www/nextcloud/apps/twofactor_backupcodes
Generating optimized autoload files (authoritative)
Generated optimized autoload files (authoritative) containing 23 classes
Regenerating autoloader for /var/www/nextcloud/apps/updatenotification
Generating optimized autoload files (authoritative)
Generated optimized autoload files (authoritative) containing 9 classes
Regenerating autoloader for /var/www/nextcloud/apps/user_ldap
Generating optimized autoload files (authoritative)
Generated optimized autoload files (authoritative) containing 63 classes
Regenerating autoloader for /var/www/nextcloud/apps/workflowengine
Generating optimized autoload files (authoritative)
Generated optimized autoload files (authoritative) containing 30 classes
The autoloaders are not up to date
Please run: bash build/autoloaderchecker.sh
And commit the result |
rullzer
force-pushed
the
enh/social-index
branch
from
69f3dca
to
7c6511e
Compare
Signed-off-by: call-me-matt <nextcloud@matthiasheinisch.de>
rullzer
force-pushed
the
enh/social-index
branch
from
7c6511e
to
22cf544
Compare
|
Updated autoloaders. |
rullzer
requested review from
nickvergessen,
skjnldsv,
juliushaertl and
ChristophWurst
ChristophWurst
approved these changes
Dec 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-up from #22085
Signed-off-by: call-me-matt nextcloud@matthiasheinisch.de