Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable19] fix possible leaking scope in WorkFlow #22410

Merged
merged 2 commits into from
Aug 26, 2020

Conversation

backportbot-nextcloud[bot]
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Aug 25, 2020

⚠️ This backport had conflicts and is incomplete ⚠️ this is fine

backport of #22359

- a configured flow can be brought into consideration, despite its event
  was not fired
- it could either run through
- or run into a RuntimeException and killing processing of valid flows

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz blizzz added the 3. to review Waiting for reviews label Aug 25, 2020
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz blizzz added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 25, 2020
@rullzer rullzer merged commit c9a1379 into stable19 Aug 26, 2020
@rullzer rullzer deleted the backport/22359/stable19 branch August 26, 2020 18:22
@rullzer rullzer mentioned this pull request Sep 4, 2020
@MorrisJobke MorrisJobke mentioned this pull request Sep 9, 2020
@aignerat aignerat changed the title [stable19] fix possible leaking scope in Flow [stable19] fix possible leaking scope in WorkFlow Sep 16, 2020
@aignerat
Copy link
Member

adjusted headline, because Flow alone could be mistaken for loginFlow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: workflows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants