Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Status: Display hint that DND mutes all notifications #22424

Merged
merged 1 commit into from
Aug 31, 2020

Conversation

georgehrke
Copy link
Member

73947C1A-92C4-4607-9FB3-C7BECE6E088F

@georgehrke
Copy link
Member Author

Should we merge after review or wait until the notifications app was actually adapted to respect the user-status?

@nickvergessen
Copy link
Member

Here we go:
nextcloud/notifications#724

@nickvergessen
Copy link
Member

Reviews please

@georgehrke
Copy link
Member Author

Let me rebase

@georgehrke georgehrke force-pushed the feature/noid/dnd_will_mute_notifications branch from 8cae83e to 240d874 Compare August 31, 2020 12:23
@nickvergessen nickvergessen added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 31, 2020
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
@georgehrke georgehrke force-pushed the feature/noid/dnd_will_mute_notifications branch from 240d874 to dbef68b Compare August 31, 2020 14:56
@georgehrke
Copy link
Member Author

Rebased yet again

@faily-bot
Copy link

faily-bot bot commented Aug 31, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 32480: failure

mysql8.0-php7.2

Show full log
There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) Test\Files\Cache\QuerySearchHelperTest::testComparison with data set #5 (OC\Files\Search\SearchComparison Object (...), array(0, 1))
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
 Array (
-    0 => 0
-    1 => 442
+    0 => '441'
+    1 => '442'
 )

/drone/src/tests/lib/Files/Cache/QuerySearchHelperTest.php:212

postgres9-php7.3

Show full log
There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) OCA\Files_Versions\Tests\VersioningTest::testRestoreMovedShare
File content has not changed
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'version 2'
+'version 1'

/drone/src/apps/files_versions/tests/VersioningTest.php:729

@georgehrke georgehrke merged commit 6b835e3 into master Aug 31, 2020
@georgehrke georgehrke deleted the feature/noid/dnd_will_mute_notifications branch August 31, 2020 15:45
@rullzer rullzer mentioned this pull request Sep 1, 2020
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants