dont use false as cache key for non utf8 path in normalizePath

[icewind1991]

since json_encode returns false if it's input isn't utf8, all non utf8 paths passed to normalizePath will currently return the same cached result.

Fixing this makes working with non utf8 storages a little bit more possible for apps

Signed-off-by: Robin Appelman robin@icewind.nl

[faily-bot]

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 32484: failure

sqlite

Show full log

There was 1 error:

1) OCA\Files_Sharing\Tests\SharedMountTest::testPermissionMovedGroupShare with data set #22 ('folder', 1, 15)
Error: Call to a member function getMountPoint() on null

/drone/src/lib/private/Share20/Manager.php:304
/drone/src/lib/private/Share20/Manager.php:705
/drone/src/apps/files_sharing/tests/TestCase.php:255
/drone/src/apps/files_sharing/tests/SharedMountTest.php:355

--

There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

mysql8.0-php7.2

Show full log

There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) Test\Share20\DefaultShareProviderTest::testGetSharedWithWithDeletedFile with data set #3 (1, true)
Failed asserting that actual size 1 matches expected size 0.

/drone/src/tests/lib/Share20/DefaultShareProviderTest.php:1271

[kesselb]

Out of curiosity: Something like md5($path) would not work 🤔

[kesselb]

Also using a json object as cache key seems super weird 🤣

[juliushaertl]

Out of curiosity: Something like md5($path) would not work thinking

No, since the resulting path stored in the cache depends on all the method parameters