Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dashboard statuses toggling #22531

Merged
merged 1 commit into from
Sep 4, 2020
Merged

Fix dashboard statuses toggling #22531

merged 1 commit into from
Sep 4, 2020

Conversation

julien-nc
Copy link
Member

Fix empty php array becoming an array instead of an object when passed to UI. This was preventing statuses state saving if default value was loaded.

refs #22468

@julien-nc
Copy link
Member Author

Then we don't need to specify the default twice, since it is set below anyways if the default value cannot be parsed.

@juliushaertl Right.

Just to be clear, I think

$statuses = ($statuses && count($statuses) > 0) ? $statuses : ['weather' => true];

is necessary to make sure the case of having '{}' stored in preferences is handled safely.

This was referenced Sep 3, 2020
…t in UI

Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
@faily-bot
Copy link

faily-bot bot commented Sep 4, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 32662: failure

acceptance-app-files

  • tests/acceptance/features/app-files.feature:108
Show full log
  Scenario: show shares                                               # /drone/src/tests/acceptance/features/app-files.feature:108
    Given I am logged in                                              # LoginPageContext::iAmLoggedIn()
    And I share the link for "welcome.txt"                            # FilesAppSharingContext::iShareTheLinkFor()
    When I open the "Shares" section                                  # AppNavigationContext::iOpenTheSection()
    Then I see that the current section is "Shares"                   # AppNavigationContext::iSeeThatTheCurrentSectionIs()
    Then I see that the file list contains a file named "welcome.txt" # FileListContext::iSeeThatTheFileListContainsAFileNamed()
      Row for file welcome.txt in file list could not be found after 100 seconds (NoSuchElementException)

@julien-nc
Copy link
Member Author

/compile amend /

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 4, 2020
@skjnldsv skjnldsv merged commit 0ed8d1c into master Sep 4, 2020
@skjnldsv skjnldsv deleted the fix/save-statuses branch September 4, 2020 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants