Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coalesce RewriteCond lines in .htaccess #22628

Merged
merged 1 commit into from Jun 16, 2021
Merged

Coalesce RewriteCond lines in .htaccess #22628

merged 1 commit into from Jun 16, 2021

Conversation

Sp1l
Copy link
Contributor

@Sp1l Sp1l commented Sep 6, 2020

And escape some '.' where not yet escaped

@skjnldsv skjnldsv added 3. to review Waiting for reviews bug labels Oct 31, 2020
MorrisJobke
MorrisJobke approved these changes Nov 4, 2020
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍

@nickvergessen nickvergessen removed their request for review November 16, 2020 14:36
This was referenced Dec 14, 2020
Merged
Merged
This was referenced Dec 28, 2020
Merged
Merged
@rullzer rullzer modified the milestones: Nextcloud 21, Nextcloud 22 Jan 8, 2021
@J0WI J0WI added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 28, 2021
@J0WI
Copy link
Contributor

J0WI commented Apr 28, 2021

@Sp1l could you please rebase and fix https://github.com/nextcloud/server/pull/22628/checks?check_run_id=1078050924

@MorrisJobke MorrisJobke mentioned this pull request May 20, 2021
Merged
@MorrisJobke MorrisJobke added 2. developing Work in progress and removed 4. to release Ready to be released and/or waiting for tests to finish labels May 20, 2021
@MorrisJobke MorrisJobke mentioned this pull request May 26, 2021
Merged
98 tasks
@blizzz blizzz mentioned this pull request Jun 2, 2021
Merged
57 tasks
@Sp1l @skjnldsv
Coalesce RewriteCond lines in .htaccess
f784207 
And escape some '.' where not yet escaped
@skjnldsv skjnldsv force-pushed the simplify-htaccess-rewrites branch from bfd6ea4 to f784207 Compare June 2, 2021 15:32
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Jun 2, 2021
@blizzz blizzz requested a review from LukasReschke June 3, 2021 14:14
@MorrisJobke MorrisJobke mentioned this pull request Jun 10, 2021
Merged
59 tasks
@blizzz blizzz mentioned this pull request Jun 16, 2021
Merged
45 tasks
@blizzz
Copy link
Member

blizzz commented Jun 16, 2021

CI is unhappy

@J0WI
Copy link
Contributor

J0WI commented Jun 16, 2021

The failing UI tests are not related to this change

@LukasReschke LukasReschke merged commit f8add9d into nextcloud:master Jun 16, 2021
@welcome
Copy link

welcome bot commented Jun 16, 2021

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@J0WI J0WI J0WI approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@rullzer rullzer Awaiting requested review from rullzer

@kesselb kesselb Awaiting requested review from kesselb

@blizzz blizzz Awaiting requested review from blizzz

@LukasReschke LukasReschke Awaiting requested review from LukasReschke

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish bug
Projects
None yet
Milestone
Nextcloud 22
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@Sp1l @J0WI @blizzz @MorrisJobke @skjnldsv @rullzer @LukasReschke