Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Increase html body height to full content height" #22773

Merged
merged 1 commit into from
Sep 10, 2020

Conversation

nickvergessen
Copy link
Member

Reverts #22614

Since quite some apps are published already, I think it's too late in the cycle for a breaking change like this

Dashboard Talk
Background not stretched Input missing and scrollbar of chat is outside
Bildschirmfoto von 2020-09-10 13-18-22 Bildschirmfoto von 2020-09-10 13-30-32

@raimund-schluessler
Copy link
Member

Fine with me, but what is the alternative for fixing all the actions menus then? I think it's not an option either to leave them broken nextcloud-libraries/nextcloud-vue#1384

@nickvergessen
Copy link
Member Author

Maybe something along the lines of this on the Actions?

:boundaries-element="document.querySelector('#app-content')

@raimund-schluessler
Copy link
Member

Maybe something along the lines of this on the Actions?

:boundaries-element="document.querySelector('#app-content')

#app-content does not work, because it does not include the header bar. The alternative would be #content, but this won't work for Vue apps, since it will be replaced by #content-vue as soon as the app loaded. Hence it will e.g. break the status select popover because it bound to #content which does not exist anymore after app load. #content-vue obviously does not work either, because not all apps are vue apps 🙈

That's basically why I came up with min-height: 100%.

Let's see if someone else finds a better solution. 🙏

@raimund-schluessler
Copy link
Member

@nickvergessen With which version of Talk did you test it? On my production server (NC19.0.2 with Talk 9.0.3) nothing happens when I add min-height: 100% to body. But I didn't test it with NC latest master yet.

@raimund-schluessler
Copy link
Member

@nickvergessen With which version of Talk did you test it? On my production server (NC19.0.2 with Talk 9.0.3) nothing happens when I add min-height: 100% to body. But I didn't test it with NC latest master yet.

Ok, on Chrome it creates issues. I only tested with Firefox so far.

@nickvergessen
Copy link
Member Author

Well I tested with master of Talk on our Talk testing server.

#app-content does not work, because it does not include the header bar.

Well you can specify another boundaries-element for those. you need to always specify it with the current parent as I understood it.

@raimund-schluessler
Copy link
Member

Well you can specify another boundaries-element for those.

The thing is, I didn't find a boundaries-element which properly works for vue as well as non-vue apps. And it has to work for both, as soon as you use the actions outside of a vue app container, e.g. as the status select popover. But I would be more than happy to be proven wrong 😅

you need to always specify it with the current parent as I understood it.

I think I don't understand what you mean.

@nickvergessen nickvergessen merged commit f91a85c into master Sep 10, 2020
@nickvergessen nickvergessen deleted the revert-22614-fix/22606/popover-boundaries branch September 10, 2020 12:57
@rullzer rullzer mentioned this pull request Sep 10, 2020
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews design Design, UI, UX, etc. regression
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants