Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix recommendation design details #22866

Merged
merged 3 commits into from
Sep 16, 2020
Merged

Fix recommendation design details #22866

merged 3 commits into from
Sep 16, 2020

Conversation

jancborchardt
Copy link
Member

Ref #22864

  • Loading spinner color is off
  • Icons have alternative text, should not have since they are decorative → empty alt=""

@jancborchardt
Recommended apps: Empty alt text since the app logo is decorative
f59af60 
Signed-off-by: Jan C. Borchardt <hey@jancborchardt.net>
@jancborchardt
Recommended apps: Fix loading spinner color
38dd302 
Signed-off-by: Jan C. Borchardt <hey@jancborchardt.net>
@jancborchardt
Recommendations recompile
1661f32 
Signed-off-by: Jan C. Borchardt <hey@jancborchardt.net>
@jancborchardt jancborchardt added bug design Design, UI, UX, etc. 3. to review Waiting for reviews feature: recommended apps labels Sep 15, 2020
@jancborchardt jancborchardt added this to the Nextcloud 20 milestone Sep 15, 2020
@MorrisJobke MorrisJobke merged commit e392525 into master Sep 16, 2020
@MorrisJobke MorrisJobke deleted the fix/recommendations-alt branch September 16, 2020 11:41
@MorrisJobke MorrisJobke mentioned this pull request Sep 16, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliushaertl juliushaertl juliushaertl approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@julien-nc julien-nc Awaiting requested review from julien-nc

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug design Design, UI, UX, etc. feature: recommended apps
Projects
None yet
Milestone
Nextcloud 20
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jancborchardt @juliushaertl @skjnldsv @MorrisJobke