Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create proper target path for shared storage fopen event #22902

Merged
merged 1 commit into from
Sep 17, 2020

Conversation

MorrisJobke
Copy link
Member

@MorrisJobke MorrisJobke commented Sep 17, 2020

Extracted from #16696 by @yahesh

This event isn't used anywhere, but better provide correct information.

Before:
Bildschirmfoto 2020-09-17 um 09 51 33

After:
Bildschirmfoto 2020-09-17 um 09 49 12

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@faily-bot
Copy link

faily-bot bot commented Sep 17, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 33144: failure

mariadb10.1-php7.2

Show full log
There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) OCA\Files_Versions\Tests\VersioningTest::testRestoreMovedShare
File content has not changed
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'version 2'
+'version 1'

/drone/src/apps/files_versions/tests/VersioningTest.php:729

acceptance-app-files-sharing

  • tests/acceptance/features/app-files-sharing.feature:338
Show full log
  Scenario: sharee can revoke create permission from reshare after the sharer disabled it # /drone/src/tests/acceptance/features/app-files-sharing.feature:338
    Given I act as John                                                                   # ActorContext::iActAs()
    And I am logged in as the admin                                                       # LoginPageContext::iAmLoggedInAsTheAdmin()
    And I act as Jane                                                                     # ActorContext::iActAs()
    And I am logged in                                                                    # LoginPageContext::iAmLoggedIn()
    And I act as Jim                                                                      # ActorContext::iActAs()
    And I am logged in as "user1"                                                         # LoginPageContext::iAmLoggedInAs()
    And I act as John                                                                     # ActorContext::iActAs()
    And I create a new folder named "Shared folder"                                       # FileListContext::iCreateANewFolderNamed()
    And I see that the file list contains a file named "Shared folder"                    # FileListContext::iSeeThatTheFileListContainsAFileNamed()
    And I share "Shared folder" with "user0"                                              # FilesAppSharingContext::iShareWith()
    And I see that the file is shared with "user0"                                        # FilesAppSharingContext::iSeeThatTheFileIsSharedWith()
    And I act as Jane                                                                     # ActorContext::iActAs()
    And I open the Files app                                                              # FilesAppContext::iOpenTheFilesApp()
    And I share "Shared folder" with "user1"                                              # FilesAppSharingContext::iShareWith()
    And I see that the file is shared with "user1"                                        # FilesAppSharingContext::iSeeThatTheFileIsSharedWith()
    And I act as John                                                                     # ActorContext::iActAs()
    And I set the share with "user0" as not creatable                                     # FilesAppSharingContext::iSetTheShareWithAsNotCreatable()
    And I see that "user0" can not create in the share                                    # FilesAppSharingContext::iSeeThatCanNotCreateInTheShare()
    And I act as Jim                                                                      # ActorContext::iActAs()
    And I open the Files app                                                              # FilesAppContext::iOpenTheFilesApp()
    And I enter in the folder named "Shared folder"                                       # FileListContext::iEnterInTheFolderNamed()
    And I create a new folder named "Subfolder"                                           # FileListContext::iCreateANewFolderNamed()
    And I see that the file list contains a file named "Subfolder"                        # FileListContext::iSeeThatTheFileListContainsAFileNamed()
    When I act as Jane                                                                    # ActorContext::iActAs()
    And I open the Files app                                                              # FilesAppContext::iOpenTheFilesApp()
    And I open the details view for "Shared folder"                                       # FileListContext::iOpenTheDetailsViewFor()
    And I see that the details view is open                                               # FilesAppContext::iSeeThatTheDetailsViewIsOpen()
    And I open the "Sharing" tab in the details view                                      # FilesAppContext::iOpenTheTabInTheDetailsView()
    And I see that the "Sharing" tab in the details view is eventually loaded             # FilesAppContext::iSeeThatTheTabInTheDetailsViewIsEventuallyLoaded()
    And I set the share with "user1" as not creatable                                     # FilesAppSharingContext::iSetTheShareWithAsNotCreatable()
    Then I see that "user1" can not create in the share                                   # FilesAppSharingContext::iSeeThatCanNotCreateInTheShare()
    And I see that "user1" can not be allowed to create in the share                      # FilesAppSharingContext::iSeeThatCanNotBeAllowedToCreateInTheShare()
    And I act as Jim                                                                      # ActorContext::iActAs()
    And I open the Files app                                                              # FilesAppContext::iOpenTheFilesApp()
    And I enter in the folder named "Shared folder"                                       # FileListContext::iEnterInTheFolderNamed()
    And I see that it is not possible to create new files                                 # FileListContext::iSeeThatItIsNotPossibleToCreateNewFiles()
      Failed asserting that true is false.

acceptance-app-theming

  • tests/acceptance/features/app-theming.feature:17
Show full log
  Scenario: resetting the color updates the header color                       # /drone/src/tests/acceptance/features/app-theming.feature:17
    Given I am logged in as the admin                                          # LoginPageContext::iAmLoggedInAsTheAdmin()
    And I visit the settings page                                              # SettingsMenuContext::iVisitTheSettingsPage()
    And I open the "Theming" section                                           # AppNavigationContext::iOpenTheSection()
    And I see that the color selector in the Theming app has loaded            # ThemingAppContext::iSeeThatTheColorSelectorInTheThemingAppHasLoaded()
    And I set the "Color" parameter in the Theming app to "#C9C9C9"            # ThemingAppContext::iSetTheParameterInTheThemingAppTo()
    And I see that the parameters in the Theming app are eventually saved      # ThemingAppContext::iSeeThatTheParametersInTheThemingAppAreEventuallySaved()
    And I see that the header color is eventually "#C9C9C9"                    # ThemingAppContext::iSeeThatTheHeaderColorIsEventually()
    When I reset the "Color" parameter in the Theming app to its default value # ThemingAppContext::iSetTheParameterInTheThemingAppToItsDefaultValue()
    Then I see that the parameters in the Theming app are eventually saved     # ThemingAppContext::iSeeThatTheParametersInTheThemingAppAreEventuallySaved()
      The 'Saved' status messages in Theming app has not been shown after 100 seconds
    And I see that the header color is eventually "#0082C9"                    # ThemingAppContext::iSeeThatTheHeaderColorIsEventually()

@MorrisJobke MorrisJobke merged commit 681e51c into master Sep 17, 2020
@MorrisJobke MorrisJobke deleted the fix/16696/proper-target-path-for-share-event branch September 17, 2020 09:53
@MorrisJobke MorrisJobke mentioned this pull request Sep 17, 2020
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants