Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dont apply encryption wrapper for root mount #22921

Merged
merged 1 commit into from
Dec 29, 2020

Conversation

icewind1991
Copy link
Member

@icewind1991 icewind1991 commented Sep 17, 2020

the shouldEncrypt already disables encryption for anything thats not in the users data folder,
however the encryption wrapper being applied anyway on the root folder breaks groupfolders

Fixes #14988

@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Sep 17, 2020
@icewind1991 icewind1991 added this to the Nextcloud 20 milestone Sep 17, 2020
@rullzer rullzer modified the milestones: Nextcloud 20, Nextcloud 21 Sep 18, 2020
@rullzer
Copy link
Member

rullzer commented Sep 18, 2020

master is NC21 now

Copy link
Member

@juliushaertl juliushaertl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works

@juliushaertl
Copy link
Member

Fixes #14988

This was referenced Dec 14, 2020
@rullzer rullzer mentioned this pull request Dec 28, 2020
39 tasks
@StarSmasher44
Copy link

Any word on this? The spam of errors on both NextCloud windows app and the logs themselves are making me really uncertain about using this or the group folders app if it doesn't even work well with its own functions.

@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 28, 2020
the `shouldEncrypt` already disables encryption for anything thats not in the users data folder,
however the encryption wrapper being applied anyway on the root folder breaks groupfolders

Signed-off-by: Robin Appelman <robin@icewind.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

path needs to be relative to the system wide data folder and point to a user specific file
5 participants