Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable18] Never copy the share link when the password is forced #23003

Merged
merged 1 commit into from Sep 29, 2020

Conversation

backportbot-nextcloud[bot]
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Sep 22, 2020

⚠️ This backport had conflicts and is incomplete ⚠️

backport of #22940

@rullzer
Copy link
Member

rullzer commented Sep 28, 2020

/compile amend /

Signed-off-by: Joas Schilling <coding@schilljs.com>
@faily-bot
Copy link

faily-bot bot commented Sep 28, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 33437: failure

mariadb10.4-php7.3

Show full log
There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) Test\Files\Cache\QuerySearchHelperTest::testComparison with data set #3 (OC\Files\Search\SearchComparison Object (...), array(0, 1))
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
 Array (
-    0 => 0
-    1 => 433
+    0 => '433'
+    1 => '434'
 )

/drone/src/tests/lib/Files/Cache/QuerySearchHelperTest.php:212

@rullzer rullzer merged commit c2262d7 into stable18 Sep 29, 2020
@rullzer rullzer deleted the backport/22940/stable18 branch September 29, 2020 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants