Make BeforeTemplateRenderedEvent aware of the actual response #23012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliushaertl
requested review from
rullzer,
nickvergessen and
ChristophWurst
nickvergessen
approved these changes
Sep 23, 2020
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
rullzer
force-pushed
the
enh/template-reponse-renderas
branch
from
56307a9
to
8ab2422
Compare
rullzer
reviewed
Sep 24, 2020
| @@ -61,7 +62,7 @@ public function handle(Event $event): void { | |||
| return; | |||
| } | |||
|
|
|||
| if (!$event->isLoggedIn()) { | |||
| if (!$event->isLoggedIn() || $event->getResponse()->getRenderAs() !== TemplateResponse::RENDER_AS_USER) { | |||
There was a problem hiding this comment.
The issue I see here is that there will be a lot of places where we will never do this check.
But yeah I don't see any other solutiopn either as an extra event will also just have this loaded on each page.
rullzer
approved these changes
Sep 24, 2020
|
Backport? |
|
/backport to stable20 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this listeners can make there rendering dependent on the actual TemplateResponse. As an example the user_status app can only register the menu if a template with the user base template is returned.
Not sure if backporting to 20 would still be fine, though it might be nice to save some additional processing time on requests that use a blank template response like Collabora/ONLYOFFICE.
As a separate note, the user_status script has a special performance impact due to the emoji picker being loaded immediately, which is quite expensive, so this would be something where we also can improve the loading time for the user template, but I'd tackle that in a separate PR once i found a good solution.