Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring back grouping for activities #2335

Merged
merged 2 commits into from
Nov 28, 2016
Merged

Bring back grouping for activities #2335

merged 2 commits into from
Nov 28, 2016

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Nov 25, 2016 •
edited
Loading

Steps

  1. Upload two different files as the same user
  2. Modify the same file as two different users
  3. Check that you have only 2 activity rows for all 4 events

Fix #2374

@nickvergessen
Working towards groups
5ba2b1c 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Add an event merger and use it for the files activities
da94685 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added this to the Nextcloud 11.0 milestone Nov 25, 2016
@mention-bot
Copy link

@nickvergessen, thanks for your PR! By analyzing the history of the files in this pull request, we identified @LukasReschke, @icewind1991 and @BernhardPosselt to be potential reviewers.

This was referenced Nov 25, 2016
Merged
Closed
@LukasReschke
Copy link
Member

LGTM

@MorrisJobke
Copy link
Member

Tested and works 👍

@MorrisJobke MorrisJobke merged commit a12d2e6 into master Nov 28, 2016
@MorrisJobke MorrisJobke deleted the grouping-for-activities branch November 28, 2016 15:18
This was referenced Jan 16, 2022
Open
Open
Open
Open
Open
Open
Open
Open
Open
@snyk-bot snyk-bot mentioned this pull request Oct 7, 2022
Open
@TomG736 TomG736 mentioned this pull request Oct 8, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasReschke LukasReschke LukasReschke approved these changes

Assignees
No one assigned
Labels
3. to review Waiting for reviews feature: activity and notification feature: files
Projects
None yet
Milestone
Nextcloud 11.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nickvergessen @mention-bot @LukasReschke @MorrisJobke