Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use public share fileclient when available #2341

Merged
merged 1 commit into from
Nov 28, 2016

Conversation

icewind1991
Copy link
Member

Fixes #2334

Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Nov 25, 2016
@icewind1991 icewind1991 added this to the Nextcloud 11.0 milestone Nov 25, 2016
@mention-bot
Copy link

@icewind1991, thanks for your PR! By analyzing the history of the files in this pull request, we identified @tanghus, @DeepDiver1975 and @butonic to be potential reviewers.

@icewind1991
Copy link
Member Author

cc @schiessle @LukasReschke

@nickvergessen
Copy link
Member

Fixes the 401 call, but the layout is broken:

bildschirmfoto vom 2016-11-28 10-37-45

Also the empty message should say something about "no folders" instead of "no files" when there are no folders in the share:

bildschirmfoto vom 2016-11-28 10-36-05

@icewind1991
Copy link
Member Author

Fixes the 401 call, but the layout is broken:

#2342

@schiessle
Copy link
Member

tested, works! 👍

@LukasReschke
Copy link
Member

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants