add dry-run option to files_external:notify #23444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icewind1991
force-pushed
the
notify-dry-run
branch
from
c1e354a
to
8592da4
Compare
kesselb
reviewed
Oct 14, 2020
kesselb
reviewed
Oct 14, 2020
|
@icewind1991 can you address the comments and rebase to win CI ? |
icewind1991
force-pushed
the
notify-dry-run
branch
2 times, most recently
from
f2b4446
to
4509142
Compare
and add some additional logging Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
notify-dry-run
branch
from
4509142
to
98c3eb6
Compare
|
done |
ChristophWurst
approved these changes
Mar 29, 2021
rullzer
approved these changes
Mar 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and add some additional logging
Signed-off-by: Robin Appelman robin@icewind.nl