Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not show shares of disabled users #23695

Closed
wants to merge 1 commit into from

Conversation

rullzer
Copy link
Member

@rullzer rullzer commented Oct 26, 2020

If a user is disabled their shares should be disabled as well.
This makes sure that if the owner of a share is disabled nobody receives
those shares anymore.

The sharer can be disabled as it is not their data that is shared.

Signed-off-by: Roeland Jago Douma roeland@famdouma.nl

If a user is disabled their shares should be disabled as well.
This makes sure that if the owner of a share is disabled nobody receives
those shares anymore.

The sharer can be disabled as it is not their data that is shared.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@nickvergessen
Copy link
Member

This means it will resync once the account is enabled again 🙈

@rullzer
Copy link
Member Author

rullzer commented Oct 26, 2020

This means it will resync once the account is enabled again 🙈

Yeah. But so be it I guess... Or should we make it a config.php thing?

@MorrisJobke
Copy link
Member

This means it will resync once the account is enabled again 🙈

Can't we make it "temporarily unavailable" like with external storages? Then the name is at least blocked and it does not cause sync issues.

@rullzer
Copy link
Member Author

rullzer commented Oct 28, 2020

This means it will resync once the account is enabled again see_no_evil

Can't we make it "temporarily unavailable" like with external storages? Then the name is at least blocked and it does not cause sync issues.

Ah right i guess we can make it a failed storage....

@rullzer
Copy link
Member Author

rullzer commented Oct 28, 2020

This means it will resync once the account is enabled again see_no_evil

Can't we make it "temporarily unavailable" like with external storages? Then the name is at least blocked and it does not cause sync issues.

Ah right i guess we can make it a failed storage....

@icewind1991 could you check that?

This was referenced Dec 14, 2020
@rullzer rullzer modified the milestones: Nextcloud 21, Nextcloud 22 Dec 21, 2020
This was referenced May 20, 2021
@blizzz blizzz mentioned this pull request Jun 2, 2021
57 tasks
@blizzz blizzz modified the milestones: Nextcloud 22, Nextcloud 23 Jun 2, 2021
@MorrisJobke MorrisJobke removed their request for review July 4, 2021 11:35
@skjnldsv skjnldsv mentioned this pull request Oct 13, 2021
@skjnldsv skjnldsv modified the milestones: Nextcloud 23, Nextcloud 24 Oct 22, 2021
@skjnldsv skjnldsv mentioned this pull request Mar 24, 2022
@blizzz blizzz mentioned this pull request Mar 31, 2022
@blizzz blizzz mentioned this pull request Apr 7, 2022
@blizzz blizzz mentioned this pull request Apr 13, 2022
@blizzz blizzz modified the milestones: Nextcloud 24, Nextcloud 25 Apr 21, 2022
This was referenced Aug 12, 2022
This was referenced Aug 24, 2022
This was referenced Sep 6, 2022
@skjnldsv skjnldsv mentioned this pull request Sep 15, 2022
This was referenced Sep 20, 2022
@blizzz blizzz modified the milestones: Nextcloud 25, Nextcloud 26 Sep 22, 2022
@skjnldsv skjnldsv added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Oct 1, 2022
@blizzz blizzz mentioned this pull request Feb 1, 2023
@skjnldsv skjnldsv mentioned this pull request Feb 23, 2023
@blizzz blizzz mentioned this pull request Mar 7, 2023
@blizzz blizzz removed this from the Nextcloud 26 milestone Mar 7, 2023
@blizzz
Copy link
Member

blizzz commented Mar 7, 2023

closing for inactivity, also discussion was not finished here.

@blizzz blizzz closed this Mar 7, 2023
@nickvergessen nickvergessen deleted the fix/sharing/no_disabled_user_shares branch March 7, 2023 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants