Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GIF being converted when used as a login image #23737

Merged
merged 1 commit into from
Nov 3, 2020

Conversation

jneplokh
Copy link
Member

@jneplokh jneplokh commented Oct 27, 2020

Fixes #16232

Signed-off-by: Jacob Neplokh me@jacobneplokh.com

Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, not great considering how big gifs can be, but what the hell 🙈

Copy link
Member

@juliushaertl juliushaertl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline.

- SVGs are already there, so I just added it alongside it (as recommended by #16232 (comment))

Signed-off-by: Jacob Neplokh <me@jacobneplokh.com>
@juliushaertl juliushaertl merged commit e9af7b8 into master Nov 3, 2020
@juliushaertl juliushaertl deleted the fix-gif-login-image branch November 3, 2020 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Basic Theming: "login image" always converted to JPEG format
3 participants