Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include favorites into normal sorting when not sorting by name #2379

Closed

Conversation

nickvergessen
Copy link
Member

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added this to the Nextcloud 11.0 milestone Nov 28, 2016
@mention-bot
Copy link

@nickvergessen, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ryanwr, @butonic and @ChristophWurst to be potential reviewers.

@ChristophWurst
Copy link
Member

This feels weird. As a user I would either expect favorites to show first regardless of the sorted column or disable the feature completely as @oparoz wrote in #2350.

@MorrisJobke
Copy link
Member

cc @nextcloud/designers

@skjnldsv
Copy link
Member

Agreed with @ChristophWurst

@nickvergessen
Copy link
Member Author

Okay, fine by me.

@nickvergessen nickvergessen deleted the issue-2350-sort-favorites-into-filesize-and-time branch November 29, 2016 15:38
@jancborchardt
Copy link
Member

Yup, sorry this is strange. Especially since a very common sorting method is sorting by modified date.

And if the file isn’t important enough to be shown on top of the view, why is it favorited? I don’t see why we need a config switch here. Less settings, folks. ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants