FeaturePolicy => PermissionPolicy #23825
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rullzer
force-pushed
the
enh/permission_policy
branch
from
9123d20
to
3a935c7
Compare
rullzer
force-pushed
the
enh/permission_policy
branch
3 times, most recently
from
acbb930
to
f65ce54
Compare
|
🤖 beep boop beep 🤖 Here are the logs for the failed build: Status of 35702: failurecheckers
nodbShow full log |
Merged
|
🏓 |
Merged
Merged
Merged
This was referenced May 3, 2023
Merged
Closed
Merged
We already had the FeaturePolicy header. However this call got renamed to PermisionPolicy. Here we move this over. The old mechanism stays there it just won't get extended. So apps that use the FeaturePolicy will not stop to work. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
kesselb
force-pushed
the
enh/permission_policy
branch
from
f65ce54
to
8d9769a
Compare
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
|
Rebased the branch. |
solracsf
added
3. to review
|
CI is red 🔴 |
MichaIng
reviewed
Jun 5, 2023
| @@ -35,6 +35,7 @@ | |||
| * should require no modification at all for most use-cases. | |||
| * | |||
| * @since 17.0.0 | |||
| * @depreacted 21.0.0 use \OCP\AppFramework\Http\PermissionPolicy | |||
There was a problem hiding this comment.
Suggested change
| * @depreacted 21.0.0 use \OCP\AppFramework\Http\PermissionPolicy | |
| * @deprecated 28.0.0 use \OCP\AppFramework\Http\PermissionPolicy |
That typo appears a few more times.
MichaIng
reviewed
Jun 5, 2023
| * notice that Nextcloud ships already with sensible defaults and those policies | ||
| * should require no modification at all for most use-cases. | ||
| * | ||
| * @since 21.0.0 |
There was a problem hiding this comment.
Suggested change
| * @since 21.0.0 | |
| * @since 28.0.0 |
MichaIng
reviewed
Jun 5, 2023
Comment on lines
+352
to
+355
| /** | ||
| * @since 17.0.0 | ||
| * @depreacted 28.0.0 Use setPermissionPolicy | ||
| */ |
There was a problem hiding this comment.
Suggested change
| /** | |
| * @since 17.0.0 | |
| * @depreacted 28.0.0 Use setPermissionPolicy | |
| */ | |
| /** | |
| * @since 28.0.0 | |
| */ |
Merged
|
As there is no feedback since a while I will close this ticket. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already had the FeaturePolicy header. However this call got renamed
to PermisionPolicy. Here we move this over. The old mechanism stays
there it just won't get extended. So apps that use the FeaturePolicy
will not stop to work.
Signed-off-by: Roeland Jago Douma roeland@famdouma.nl