Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only filter submounts for fileinfo on demand #23865

Closed
wants to merge 1 commit into from

Conversation

icewind1991
Copy link
Member

this removes the need to always setup all the sub storages when getting a folder info

Signed-off-by: Robin Appelman robin@icewind.nl

this removes the need to always setup all the sub storages when getting a folder info

Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Nov 3, 2020
@icewind1991 icewind1991 added this to the Nextcloud 21 milestone Nov 3, 2020
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code makes sense, but those negations combined with multiple && and || doesn't make it easy to read 🙈

@faily-bot
Copy link

faily-bot bot commented Nov 3, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 34964: failure

acceptance-app-files-sharing-link

  • tests/acceptance/features/app-files-sharing-link.feature:26
Show full log
  Scenario: show download again in a public shared link             # /drone/src/tests/acceptance/features/app-files-sharing-link.feature:26
    Given I act as John                                             # ActorContext::iActAs()
    And I am logged in                                              # LoginPageContext::iAmLoggedIn()
    And I share the link for "welcome.txt"                          # FilesAppSharingContext::iShareTheLinkFor()
    And I set the download of the shared link as hidden             # FilesAppSharingContext::iSetTheDownloadOfTheSharedLinkAsHidden()
    And I set the download of the shared link as shown              # FilesAppSharingContext::iSetTheDownloadOfTheSharedLinkAsShown()
    And I write down the shared link                                # FilesAppSharingContext::iWriteDownTheSharedLink()
      Element is no longer attached to the DOM
      For documentation on this error, please visit: http://seleniumhq.org/exceptions/stale_element_reference.html
      Build info: version: '2.53.1', revision: 'a36b8b1', time: '2016-06-30 17:37:03'
      System info: host: '40c96b21a33f', ip: '172.22.0.2', os.name: 'Linux', os.arch: 'amd64', os.version: '4.15.0-76-generic', java.version: '1.8.0_91'
      Driver info: driver.version: unknown (WebDriver\Exception\StaleElementReference)
    When I act as Jane                                              # ActorContext::iActAs()
    And I visit the shared link I wrote down                        # PublicShareContext::iVisitTheSharedLinkIWroteDown()
    And I see that the current page is the shared link I wrote down # PublicShareContext::iSeeThatTheCurrentPageIsTheSharedLinkIWroteDown()
    Then I see that the download button is shown                    # PublicShareContext::iSeeThatTheDownloadButtonIsShown()
    And I open the Share menu                                       # PublicShareContext::iOpenTheShareMenu()
    And I see that the Share menu is shown                          # PublicShareContext::iSeeThatTheShareMenuIsShown()

@rullzer
Copy link
Member

rullzer commented Nov 12, 2020

Is this still needed?

This was referenced Dec 14, 2020
@rullzer rullzer modified the milestones: Nextcloud 21, Nextcloud 22 Dec 23, 2020
@MorrisJobke MorrisJobke mentioned this pull request May 20, 2021
@MorrisJobke
Copy link
Member

Is this still needed?

I guess not.

@MichaIng MichaIng deleted the lazy-filter-submounts branch July 15, 2021 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants