Add option to set weather forecast offset #24193
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-nc
requested review from
jancborchardt,
ChristophWurst,
GretaD,
skjnldsv and
marcoambrosini
|
Yeah, the UX doesn't seems intuitive, you need @jancborchardt's take on this :) |
added 2 commits
November 26, 2020 11:15
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
julien-nc
force-pushed
the
enh/23399/variable-weather-forecast-offset
branch
from
c47b390
to
75404fb
Compare
julien-nc
changed the title
julien-nc
added
3. to review
|
Fixed Psalm warning, rebased on master, it's ready imho. |
|
I don't think we should add this, since the intention is:
So e.g. at 23:00 one shouldn't get the forecast for 5:00 the next day, but a general forecast for the next day. |
|
Maybe this kind of advanced feature belongs somewhere else, in a weather app or a dedicated weather widget. |
ChristophWurst
deleted the
enh/23399/variable-weather-forecast-offset
branch
|
Uhhh... well right now the weather thing sucks. I get that there are some people who think it is better to see the weather 3 hours ahead but 90% of the people using my next cloud install always text me saying "why is the time wrong" and I've found found myself asking that myself. it should be configurable systemwide in the settings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #23399
How about letting users set the forecast offset?
This adds a setting in the weather widget action menu to tell how many hours in advance we want to see the weather forecast. It has to be between 0 (now) and 9 hours ahead.
As we get 10 hours weather range on each forecast request, no query is needed when changing the offset, it has an immediate effect on the widget.
The "play-next" icon might not be very explicit.
Do we want this?
If yes, how do we make it more explicit?