Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable18] Avoid substr() error when strpos returns false #24371

Merged
merged 2 commits into from Nov 25, 2020
Merged

[stable18] Avoid substr() error when strpos returns false #24371

merged 2 commits into from Nov 25, 2020

Conversation

backportbot-nextcloud[bot]
Copy link

backport of #21844

bladewing and others added 2 commits November 25, 2020 11:55
@bladewing @backportbot
Avoid substr() error when strpos returns false
0057f85 
"Exception: substr() expects parameter 3 to be int, bool given" can occur on Line 378 $mimePart = substr($icon, 0, strpos($icon, '-'));
This happens, when '-' is not found and strpos returns false instead of an int.
When this occurs, e.g., Activity hangs.

Signed-off-by: lui87kw <lukas.ifflaender@uni-wuerzburg.de>
@bladewing @backportbot
Extra white space to follow other ifs
3952be0 
Signed-off-by: lui87kw <lukas.ifflaender@uni-wuerzburg.de>
@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 18.0.12 milestone Nov 25, 2020
@rullzer rullzer added the 3. to review Waiting for reviews label Nov 25, 2020
@faily-bot
Copy link

faily-bot bot commented Nov 25, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 35943: failure

webpack-build

handlebars

sqlite

Show full log 
There was 1 error:

1) OCA\Files_Sharing\Tests\EtagPropagationTest::testRecipientDeleteInShare
Error: Call to a member function getMountPoint() on null

/drone/src/lib/private/Share20/Manager.php:305
/drone/src/lib/private/Share20/Manager.php:707
/drone/src/apps/files_sharing/tests/EtagPropagationTest.php:142
/drone/src/apps/files_sharing/tests/PropagationTestCase.php:42

--

There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

@rullzer rullzer merged commit 71b176d into stable18 Nov 25, 2020
@rullzer rullzer deleted the backport/21844/stable18 branch November 25, 2020 13:42
This was referenced Dec 1, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer rullzer approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@bladewing bladewing Awaiting requested review from bladewing

@juliushaertl juliushaertl Awaiting requested review from juliushaertl

@MorrisJobke MorrisJobke Awaiting requested review from MorrisJobke

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug
Projects
None yet
Milestone
Nextcloud 18.0.12
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rullzer @ChristophWurst @bladewing