adding a ShareDeletedEvent #24610
Merged
adding a ShareDeletedEvent #24610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rullzer
requested changes
Dec 15, 2020
lib/private/Share20/Manager.php
Outdated
| @@ -1167,6 +1167,8 @@ public function deleteShare(IShare $share) { | |||
| $provider = $this->factory->getProviderForType($share->getShareType()); | |||
| $provider->delete($share); | |||
|
|
|||
| $this->dispatcher->dispatchTyped(new Share\Events\ShareDeletedEvent($share, $deletedShares)); | |||
There was a problem hiding this comment.
Mmm I'm wonering if we should not just make the event simpler. And just have the share.
And then also emit an event for all children that get deleted.
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzer
force-pushed
the
enh/adding-missing-event-on-deleted-shares
branch
from
b986ece
to
bb411c7
Compare
rullzer
approved these changes
Dec 23, 2020
lib/private/Share20/Manager.php
Outdated
| @@ -1167,6 +1167,8 @@ public function deleteShare(IShare $share) { | |||
| $provider = $this->factory->getProviderForType($share->getShareType()); | |||
| $provider->delete($share); | |||
|
|
|||
| $this->dispatcher->dispatchTyped(new Share\Events\ShareDeletedEvent($share, $deletedShares)); | |||
ChristophWurst
approved these changes
Dec 23, 2020
ChristophWurst
added
4. to release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
seems it was missing since the Great Migration. should includes parent IShare, and children